Skip to content

Clean up the C/C++ compiler variable tests #4711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

mwichmann
Copy link
Collaborator

@mwichmann mwichmann commented Apr 10, 2025

Tests now don't combine flags-only cases (don't use a real compiler) with live cases (do require a compiler) in the same test file.

This differs from #4693 as that one worked on *FLAGS variables, this one works on the variables naming the compilers (CC, CXX and shared-lib variants).

This is a test-only change, no doc impacts.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

Tests now don't combine flags-only cases (don't use a real compiler)
with live cases (do require a compiler) in the same test file.

Signed-off-by: Mats Wichmann <[email protected]>
@mwichmann mwichmann added the testsuite Things that only affect the SCons testing. Do not use just because a PR has tests. label Apr 10, 2025
@mwichmann mwichmann moved this to In review in Next Release Apr 10, 2025
@bdbaddog bdbaddog merged commit 34faf1b into SCons:master Apr 11, 2025
6 of 8 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Next Release Apr 11, 2025
@mwichmann mwichmann added this to the NextRelease milestone Apr 12, 2025
@mwichmann mwichmann deleted the test/cc-vars-live branch April 12, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testsuite Things that only affect the SCons testing. Do not use just because a PR has tests.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants