Repository navigation
Initialize all coordinates in global to local test - #403
Merged
Merged
Conversation
The first vertex was {0.0}, which leaves its y coordinate uninitialized:
Omega_h's Few initializer_list constructor only sets the elements given.
The test passed or failed depending on leftover stack contents; it failed
on aarch64 with gcc 14. Valgrind reported the uninitialized read.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST_CASE("global to local")intest/test_point_search.cppbuilds its triangle as{0.0}only sets the first vertex's x coordinate. Omega_h'sFew(std::initializer_list)constructor initializes just the elements it is given, so the y coordinate is whatever was on the stack. Whether the test passes depends on that leftover value: it passes on x86 and on macOS, but failed on aarch64 with gcc 14 in the scorec-spack-packages CI (SCOREC/scorec-spack-packages#36).Running
unit_testsunder valgrind reports the uninitialized read, originating in this test's stack frame; with this fix valgrind reports no errors forunit_tests.The fix gives the first vertex both coordinates:
{0.0, 0.0}.