Fix deserialization problem with new type aliases#9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a dataclasses_json deserialization TypeError triggered by PEP 695 type aliases (typing.TypeAliasType) by switching ID-related annotations away from the new type ID = str form, and adds regression tests to cover the affected serialization roundtrips.
Changes:
- Replace
ID(PEP 695 type alias) usages inpygexml.pagedataclasses with plainstrannotations for IDs and dict keys. - Add serialization roundtrip tests for
TextLine,TextRegion, andPage. - Update tests to stop importing/using
IDand type those parameters asstr.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pygexml/page.py |
Removes PEP 695 ID alias usage by annotating IDs/dict keys as str, addressing dataclasses_json deserialization failures. |
test/test_page.py |
Adds regression tests for to_dict()/from_dict() roundtrips and updates imports/type hints to match the new str ID annotations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit 32ed4eb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #8 for details. Closes #8.