Integrate 2D Signal Processing into ICARUS Reconstruction #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of two-faced ICARUS wires config.
… jsonnets for various WC SP configs. Move parameters out of json config into fcl config.
…e due to the different filter width).
…with new H5 interface). Fixes to which frames get created. Don't save H5 files by default.
|
As far as I can tell this is still a draft PR. |
|
If we want to start moving forward with this we should try to get the documentation part of the PR up to speed... As I interpret the presentation at the workshop we should not wait for the DNN ROI just yet? |
|
As this looks to be essentially ready for integration (sans DNN ROIs), can we please get this properly documented now? This is important before signing off to merge... Likely we have a couple of weeks here so hopefully not an onerous task. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title. Still just a draft for now!
Depends on external updates:
WireCell/wire-cell-toolkit#341
Also needs a WireCell version with this commit merged in:
WireCell/wire-cell-toolkit@e532442
Also needs the following files added to icarus_data:
NNs/UNet-optfilter-opaqueMC_U_Plane.ts
NNs/UNet-optfilter-opaqueMC_V_Plane.ts
NNs/UNet-randMC_U_Plane.ts
NNs/UNet-randMC_V_Plane.ts
icarus_fnal_fit_ks_P0nom_P1bin{0,1,...,14}.json.bz2
icarus_wire_twofaced.json.bz2