-
Notifications
You must be signed in to change notification settings - Fork 24
[FEATURE] Add 'flexBundle'-flag in the manifest via generateFlexChangeBundle #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…FlexChangesBundle task Currently, the runtime checks the existence of the flexibility-bundle.json depending on the preloading of the bundle itself. This preload of all component sources may not be in time for annotation changes, which are part of the preprocessing and require a more explicit hint, if the bundle is present and should be requested. This commit adds this hint with a flag in the "sap.ui5" subsection in the manifest.
|
The name of the flag is currently on review within the manifest-schema and as soon as the final go is given, the draft flag will be removed. All other code is "ready for review". |
|
If I understand this correctly, this requires a new property in the manifest schema. Doesn't this also mean, that the property can only be added when the existing manifest.json uses an |
This flag will be set by the builder. It must not be set by the developer directly, so it is not relevant for linting |
It will be set by the builder directly and not set by the developer. It is not a decision by the developer, but a fact if the developer created entities part of the flexibility-bundle.json which is then build and present in the app and its -preload. |
|
The manifest schema change is approved and merged. @matz: as @MatthiasSchmalz mentions, it is related to the manfiest-version, but having the flag does not hurt and potentially even helps, if present. Thus, I prefer keeping it independent of the version. |
|
Thanks a lot for your contribution. We will have another round of review in the team and will merge the PR afterwards. |
|
Closing this PR. Superseded by #1164. |
Add 'flexBundle'-flag in the manifest via generateFlexChangeBundle task.
Currently, the runtime checks the existence of the flexibility-bundle.json depending on the preloading of the bundle itself. This preload of all component sources may not be in time for annotation changes, which are part of the preprocessing and require a more explicit hint, if the bundle is present and should be requested. This commit adds this hint with a flag in the "sap.ui5" subsection in the manifest.
JIRA: CPOUI5FOUNDATION-1125