[Test] Test the get_discoveries cli command #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…digger into feat/cli/get_discoveries
|
Hi @alaabenfatma, tests are failing so please fix the code. If tests fail I cannot start the code review |
marcorosa
requested changes
Aug 16, 2021
|
The tests are failing. The possible reason (my guess) is that when you try to add discoveries you're not adding anything since the inserts break db rules, i.e., you can't add a discovery if you don't have the rule and the repo it references. |
marcorosa
requested changes
Aug 19, 2021
| discoveries = [] | ||
| discoveries_count = 5 | ||
| for state in ['new', 'false_positive', 'addressing', | ||
| 'not_relevant', 'fixed']: |
There was a problem hiding this comment.
wrong indentation (they should start below "new")
|
|
||
| @classmethod | ||
| def tearDownClass(cls): | ||
| # Remove the repo and all its discoveries |
There was a problem hiding this comment.
convert this into a docstring
| discoveries = [] | ||
| discoveries_count = 5 | ||
| for state in ['new', 'false_positive', 'addressing', | ||
| 'not_relevant', 'fixed']: |
There was a problem hiding this comment.
same comment as in the other file
marcorosa
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets
Note: Upon the merge of this PR, the previous PR (#164 ) can be closed since this one builds upon it. However, the latter PR can also be safely merged before this one as well (no conflicts will be raised nonetheless).
Feats: