Skip to content

Conversation

schmelter-sap
Copy link
Member

Increased the timeout for checking the file socket from 3 to 10 seconds max.

fixes #2077

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

Copy link
Member

@ArnoZeller ArnoZeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But can we also throw a JTreg SkippedException in line 103 instead of simply returning.

@schmelter-sap
Copy link
Member Author

Looks good. But can we also throw a JTreg SkippedException in line 103 instead of simply returning.

Done.

Copy link
Member

@ArnoZeller ArnoZeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

Copy link
Member

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing...

Copy link
Member

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome now.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@schmelter-sap schmelter-sap merged commit c376092 into SAP:sapmachine Oct 13, 2025
77 of 80 checks passed
@schmelter-sap schmelter-sap deleted the fix_file_socket_on_aix_for_real_this_time branch October 13, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileSocketTransportTest sometimes fails on slow machines

4 participants