feat(shared-filesystem-storage): migrates replicas to functional TypeScript (#1966)#1988
Open
hodanoori wants to merge 3 commits into
Open
feat(shared-filesystem-storage): migrates replicas to functional TypeScript (#1966)#1988hodanoori wants to merge 3 commits into
hodanoori wants to merge 3 commits into
Conversation
andypf
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
ReplicaListandReplicaItemcomponents in the shared filesystem storage plugin to TypeScript as part of the React 19 migration epic (#1774).ReplicaListis converted from a class component to a functional component;ReplicaItemwas already functional and is converted to TypeScript.Changes Made
ReplicaListwith a functional TypeScript component inlist.tsxReplicaItemfrom JSX to TypeScript initem.tsx(already functional)componentDidMountandUNSAFE_componentWillReceivePropswithuseEffect([active])inReplicaListReplica,Share,SharesState, and component props in both fileslib/policyinapp/javascript/types/global.d.tslist.test.tsxwith 9 unit tests covering loading state, table rendering, and dependency loadingitem.test.tsxwith 15 unit tests covering row rendering and actions menuRelated Issues
shared_filesystem_storage/components/replicas/list.jsx#1966Screenshots (if applicable)
Checklist