feat(tools): migrates object_topology to functional TypeScript component#1986
Open
hodanoori wants to merge 3 commits into
Open
feat(tools): migrates object_topology to functional TypeScript component#1986hodanoori wants to merge 3 commits into
hodanoori wants to merge 3 commits into
Conversation
…nt (#1964) - Replace class component App with functional component ObjectTopology - Convert state (filterCollapsed, selectedTypes, details) to useState - Replace componentDidMount/componentWillUnmount with useEffect cleanup - Replace UNSAFE_componentWillReceiveProps with useEffect([objects]) - Remove Graph.nodeLabel call (not needed in functional implementation) - Add TypeScript interfaces for TopologyObject, Details, ObjectTopologyProps - Fix onBlur to actually collapse the dropdown instead of console.log - Add object_topology.test.tsx with 21 tests covering all component behaviour
andypf
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
object_topology.jsxfrom a React class component to a functional TypeScript component as part of the React 19 migration epic (#1774).Changes Made
Appwith functional componentObjectTopologyin TypeScriptfilterCollapsed,selectedTypes,details) touseStatehookscomponentDidMount/componentWillUnmountwith a singleuseEffectwith cleanupUNSAFE_componentWillReceivePropswithuseEffectwatching theobjectspropGraph.nodeLabelcall — not needed in the functional implementationTopologyObject,Details, andObjectTopologyPropsonBluron the filter dropdown to properly collapse it instead ofconsole.logobject_topology.test.tsxwith 21 unit tests covering mount/unmount, filter dropdown, graph node/link filtering, and details popoverRelated Issues
tools/universal_search/topology/components/object_topology.jsx#1964Screenshots (if applicable)
Checklist