feat(tools): migrates ShowSearchObjectModal to React 19 #1983
Merged
Conversation
…ponent with TypeScript
andypf
reviewed
Apr 8, 2026
andypf
approved these changes
Apr 8, 2026
hgw77
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
ShowSearchObjectModalin the universal search plugin from a legacy React class component to a modern functional component with TypeScript, as part of the React 19 migration epic (#1774). The component renders a modal with tabbed content for a searched object and is now fully typed, free of deprecatedlifecycle methods, and covered by Vitest tests.
Changes Made
show.jsx— replaced entirely by the TypeScript implementationshow.tsx— functional component usinguseState/useEffecthooks:componentDidMountreplaced withuseEffect(() => {}, [])for the initial item fetchUNSAFE_componentWillReceivePropsreplaced withuseEffect([item])to reset loading state when the item arriveshide+restoreUrlmerged into a singleclosefunctionItem,AggregatesState,Match,History, andShowSearchObjectModalPropsdeclare global { var policy }added to handle the Rails-injectedpolicyglobalSpinnerandJsonViewersourced from@cloudoperators/juno-ui-components;Modal,Button,Tabs,Tabkept fromreact-bootstrap(JunoModalrequiresAppShellProviderwhich is not present in the tools plugin)show.test.tsx— comprehensive Vitest test suite covering:loadcalled on mount, cleared on item arrivalloadcached_object_typeandpolicy.isAllowed?tab=query param anduserRoles→datareset for domain itemshistory.replaceandhistory.goBacknavigationapp/javascript/react-bootstrap.d.ts— addedTabsandTabtype declarationsRelated Issues
tools/universal_search/search/components/show.jsx#1963: Migratetools/universal_search/search/components/show.jsxScreenshots (if applicable)
Checklist