Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week 4 Done? #29

Merged
merged 13 commits into from
Sep 20, 2013
Merged

Week 4 Done? #29

merged 13 commits into from
Sep 20, 2013

Conversation

mikewesthad
Copy link
Contributor

MorseDecoder is hacky, but the thought of working on it more...

@bakercp
Copy link
Member

bakercp commented Sep 19, 2013

Ha! You're a rockstar.

@bakercp
Copy link
Member

bakercp commented Sep 20, 2013

Hey, by the way, when possible I'd suggest avoiding float on the Arduino. It is not supported directly in hardware. You can read more about that here:

http://arduino.cc/en/Reference/Float

That said, I would not change your code. It's great for this assignment. float is there for convenience! But for future reference -- particularly as your projects become faster / larger it's something to keep an eye on.

By the way, if floating point math is important and you must use an Arduino, you can get math co-processors (aka FPUs) :) But suddenly a Raspberry Pi starts looking really good ...

@mikewesthad
Copy link
Contributor Author

Ah, duly noted.

Along those lines, it had not crossed my mind to check what delay(ms) takes as an argument - an unsigned long int - which makes sense now.

bakercp added a commit that referenced this pull request Sep 20, 2013
@bakercp bakercp merged commit 265f670 into SAIC-ATS:master Sep 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants