pyelftools/container.py: fix broken import #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Is this fixed upstream? Perhaps we could rebase and reapply S2E commits on top. |
|
I just took a look this is fixed upstream. Given that this fork is >150 commits behind the head repo it probably makes sense to update it. I'm not familiar with the S2E specific commits here - are they still necessary? |
If not fixed in upstream, then yes. I haven't looked at pyelftools in a couple years, so I don't know. You could try to reapply them on top of master, see if it works cleanly. |
|
Taking a look at the S2E specific commits, it doesn't look like they are complex. I'll give rebasing a shot and see what happens. |
|
Merging the quick fix before we have the more complex upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an import that breaks during project creation in Python 3.10.