Skip to content

✨ feat: file-service S3 연동#36

Merged
5nam merged 4 commits intodevelopfrom
feat/34-file-service-s3
May 26, 2025
Merged

✨ feat: file-service S3 연동#36
5nam merged 4 commits intodevelopfrom
feat/34-file-service-s3

Conversation

@5nam
Copy link
Collaborator

@5nam 5nam commented May 7, 2025

✨ feat: file-service S3 연동

  • feat: file-service 에 AWS S3 연동 완료

📌 변경 사항 (What’s changed?)

  • Club, User 엔티티에 original_img_name, stored_img_name 추가. stored_img_name 은 파일 삭제할 때 필수 값.
  • FileInfo : img_url, original_img_name, stored_img_name 객체 추가
  • fileService.upload() 반환 값 FileInfo 로 변경

⚙️ 변경 이유 (Why?)

  • 추후에 이미지 변경할 때, 삭제해야 하는데 링크를 파싱해서 삭제하는 것보다 DB에 저장해놓는 것이 유지보수 측면에서 더 좋은 로직이라고 생각함.

✅ 테스트 방법 (How to test?)

  • CloudFileServiceTest 추가

💬리뷰 요구사항

FileService의 구체적인 사용법은 정리해놓겠습니다!
코드 보시고 편하게 리뷰 남겨주세요~!

- fileService upload 반환 FileInfo 객체로 변경
- Club, User 의 프로필 이미지 imgUrl, originalImgName, storedImgName(삭제할 때 쓰이는 값, test/aaaa-aaaa-aaaa.jpg) 값 추가
@5nam 5nam self-assigned this May 7, 2025
@5nam 5nam requested review from hojooo and y3binchoi as code owners May 7, 2025 07:58
@5nam 5nam added ✨ feature New feature or request ♻️ refactor Refactor code ✅ test Add test code / Edit test code labels May 7, 2025
@5nam 5nam linked an issue May 7, 2025 that may be closed by this pull request
Copy link
Collaborator

@y3binchoi y3binchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이미지 객체 키를 추가로 저장해서 로직을 단순화 하는 방법이 좋다고 생각합니다👍🏻 수고하셨어요!!

@hojooo
Copy link
Collaborator

hojooo commented May 18, 2025

일이 있어서 이제 확인했네요 ㅠㅠ S3 연동 수고하셨습니다!

@5nam 5nam merged commit 801c9ac into develop May 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♻️ refactor Refactor code ✨ feature New feature or request ✅ test Add test code / Edit test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileService S3 연동

3 participants