Conversation
Closed
y3binchoi
approved these changes
Apr 19, 2025
Collaborator
y3binchoi
left a comment
y3binchoi
left a comment
There was a problem hiding this comment.
수고하셨습니다~!! 추가로 고려할 점을 꼼꼼히 TODO나 FIXME로 남겨두신 점도 너무 좋아요!!
| private final JPAQueryFactory queryFactory; | ||
|
|
||
| @Override | ||
| public List<Notice> findByCursor(Long cursor, int size, Club club) { |
Collaborator
There was a problem hiding this comment.
저희 클라이언트가 모바일이기 때문에 스크롤 할 것을 고려하여 커서 방식의 페이지네이션을 선택하신 점 너무 좋아요!
|
|
||
| public interface NoticeRepository extends JpaRepository<Notice, Long> { | ||
| List<Notice> findByClub(Club club); | ||
| public interface NoticeRepository extends JpaRepository<Notice, Long>, NoticeRepositoryCustom { |
Collaborator
There was a problem hiding this comment.
NotificationRepositoryImpl가 NotificationRepository의 구현체로 해석될 위험은 없을까요? 혹시 이름을 NotificationJpaRepository로 변경하는건 불필요한 일일까요?
Collaborator
Author
There was a problem hiding this comment.
아 네이밍에 대한 생각을 못했네요. Jpa로 바꾸는게 좋을 거 같습니다! 반영해서 머지하겠습니다! 좋은 피드백 감사합니다 ㅎㅎ
Collaborator
Author
There was a problem hiding this comment.
지금 오류가 나서 찾아보니까, JPA의 커스텀 리포지토리 규칙이 있다고 합니다! 그래서
XxxRepositoryCustom → 구현체명은 반드시 XxxRepositoryImpl이어야 한다고 합니다!
https://imprint.tistory.com/142
링크 공유 드립니다!
Collaborator
|
커서 기반 페이지네이션이라는 방법을 처음 알았네요. 수고하셨습니다! |
hojooo
approved these changes
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ refactor: Notice 도메인 리팩터링(공지 추가/공지 조회)
📌 변경 사항 (What’s changed?)
⚙️ 변경 이유 (Why?)
✅ 테스트 방법 (How to test?)
🤔 기타 참고 사항
💬리뷰 요구사항(선택)