master <-- Update/documentation #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead showing <no title>
…downloads/releases of software libraries and addons we create such as Rxn Rover itself, or Dynamic Reentrant library
zachcran
requested changes
Jul 25, 2025
source/first_party/analyzers/waters_patrol_uplc_report_parser.rst
Outdated
Show resolved
Hide resolved
source/first_party/analyzers/waters_patrol_uplc_report_parser.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Zachery Crandall <[email protected]>
Co-authored-by: Zachery Crandall <[email protected]>
Co-authored-by: Zachery Crandall <[email protected]>
Co-authored-by: Zachery Crandall <[email protected]>
zachcran
requested changes
Aug 7, 2025
Member
zachcran
left a comment
zachcran
left a comment
There was a problem hiding this comment.
Just a few minor nitpicks. This is 99% of the way there!
|
|
||
| - **Plugin (.vip file):** | ||
| `MilliGAT Pump Plugin – Releases <https://github.com/RxnRover/plugin_waters_patrol_uplc_report_parser/releases>`_ | ||
| `Waters Patrol UPLC Report Parser – Releases <https://github.com/RxnRover/plugin_waters_patrol_uplc_report_parser/releases>`_ |
Member
There was a problem hiding this comment.
There is no release for this plugin yet.
zachcran
requested changes
Aug 12, 2025
Co-authored-by: Zachery Crandall <[email protected]>
zachcran
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the plugin catalog to include links to the .vip package files in their github releases tab.
Updates the example submission form to include requirements, etc.
Related Issues/Pull Requests
Releases must be updated in the subsequent github directory, chromtech_nextgen (plugin/driver), etc.
However the plugin catalog already includes the correct link to the release page.