Feature/rework updatemanager #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UpdateDistributor implements IUpdateManager UpdateTracker implements IObservable<Update> Add TelegramBot.Builder Extend IUpdateManager with Set(IObservable<Update>) method Add Rx utility entities: CustomSubjects that works similar to Rx Subject DisposableAction that works as Rx Disposable.Create
Desc: It didn't apply tracker to update manager
niklasweimann
merged commit 170c120
into
RxTelegram:rework_updatemanager
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to add the ability to switch between different update streams. It allows users to switch between various streams, such as long polling, webhooks, or test streams, without needing to resubscribe to a new update manager.
Core changes:
IUpdateManagerextended with theSet(IObservable<Update>)method.UpdateManagerhas been split into two classes:UpdateDistributorandLongPollingUpdateTracker.UpdateDistributorserves as a facade that implementsIUpdateManager.LongPollingUpdateTrackerimplementsIObservable<Update>.UpdateManageris no longer needed but has been retained as is.TelegramBotclass has been extended with a Builder that allows settingIUpdateManagerandIObservable<Update>.