Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breakRetainCycle: Break retain cycle in bind(to:input:) #228

Merged
merged 4 commits into from
Jan 27, 2021

Conversation

nflahavan
Copy link
Contributor

#227

This pull request breaks the retain cycle in the various bind(to:input:) methods. Tests have also been added to ensure no retain cycle is introduced by calling bind(to:input:).

@bobgodwinx
Copy link
Member

sounds like a plan @nflahavan Thanks for spotting it out.. 👍🏾

@bobgodwinx bobgodwinx merged commit 2f2e1e2 into RxSwiftCommunity:master Jan 27, 2021
@rxswiftcommunity
Copy link

Thanks a lot for contributing @nflahavan! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants