Support acos, atan, and atan2 ops via patches#26
Open
maochuanjun wants to merge 1 commit into
Open
Conversation
2479359 to
eeedeef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for acos, atan, and atan2 mathematical operations to the Triton Python frontend.
Currently, tl.math.acos, tl.math.atan, and tl.math.atan2 are missing from the triton.language.math module in the
pinned Triton version, which causes AttributeError (Unknown Python Exception) during the AST compilation phase when
migrating and running FlagGems operators.
Changes
Added a new patch file (patches/0003-add-trig-ops-to-frontend.patch) that patches the Triton submodule
to:
Resolved
Category 3 / "Other Errors".
Test
source scripts/triton-riscv-env.sh scripts/apply_patches.sh scripts/rebuild-triton-riscv.sh pytest python/examples/flaggems/test_acos.py python/examples/flaggems/test_atan.py python/examples/flaggems/test_atan2.py python/examples/flaggems/test_angle.py -vTest Results: