Skip to content

#111: Resolve PHP 8.0 error when calling set_error_handler #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#111: Resolve PHP 8.0 error when calling set_error_handler #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/RemoteLRS.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ protected function sendRequest($method, $resource) {
// normal handling
//
set_error_handler(
function ($errno, $errstr, $errfile, $errline, array $errcontext) {
function ($errno, $errstr, $errfile, $errline) {
// "!== false" is intentional. strpos() can return 0, which is falsey, but returning
// 0 matches our "true" condition. Using strict equality to avoid that confusion.
if ($errno == E_NOTICE && strpos($errstr, 'Array to string conversion') !== false) {
Expand All @@ -162,7 +162,13 @@ function ($errno, $errstr, $errfile, $errline, array $errcontext) {
$fp = fopen($url, 'rb', false, $context);

if (! $fp) {
$content = "Request failed: $php_errormsg";
$content = "Request failed";

$last_error = error_get_last();

if($last_error && $last_error['type'] === E_ERROR) {
$content .= ": " . $last_error['message'];
}
}
}
catch (\ErrorException $ex) {
Expand Down