-
-
Notifications
You must be signed in to change notification settings - Fork 6
Add header license REUSE check #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
07921e1
to
8ec3f3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements REUSE compliance by adding standardized license headers to all source files and configuration files. This addresses issue #133 to ensure proper license attribution throughout the codebase.
- Adds SPDX license headers to all Rust source files and configuration files
- Creates REUSE.toml configuration file for license management
- Adds GitHub Actions workflow for automated REUSE compliance checking
- Includes standard license text files and removes old LICENCE file
Reviewed Changes
Copilot reviewed 23 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/*.rs | Added SPDX license headers to all Rust source files |
REUSE.toml | Configuration file defining license annotations for different file types |
.github/workflows/reuse-check.yml | New workflow for automated REUSE compliance checking |
LICENSES/*.txt | Standard license text files for BSD-3-Clause and CC0-1.0 |
README.md, Cargo.toml, .github/*.yml | Added license headers to configuration and documentation files |
LICENCE | Removed old license file in favor of standardized LICENSES directory |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
#![cfg(feature = "gui")] | ||
|
||
// SPDX-FileCopyrightText: 2025 RustInFinance | ||
// | ||
// SPDX-License-Identifier: BSD-3-Clause | ||
|
Copilot
AI
Sep 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license header should be placed at the very beginning of the file, before any other directives including #![cfg(...)]
. This ensures the license information is the first thing seen in the file.
#![cfg(feature = "gui")] | |
// SPDX-FileCopyrightText: 2025 RustInFinance | |
// | |
// SPDX-License-Identifier: BSD-3-Clause | |
// SPDX-FileCopyrightText: 2025 RustInFinance | |
// | |
// SPDX-License-Identifier: BSD-3-Clause | |
#![cfg(feature = "gui")] |
Copilot uses AI. Check for mistakes.
|
b1eb48b
to
1c0c246
Compare
@@ -1,3 +1,7 @@ | |||
// SPDX-FileCopyrightText: 2025 RustInFinance | |||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of these empty lines, can you remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be doable with templates:
Source fsfe/reuse-tool#562
Automatic tool should check if license header exists in source files.
Related issue #133