x509-cert: add DirectoryString::BmpString
#1794
Open
+55
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dishmaker
commented
May 2, 2025
| fn as_ref(&self) -> &str { | ||
| match self { | ||
| Self::PrintableString(s) => s.as_ref(), | ||
| Self::TeletexString(s) => s.as_ref(), | ||
| Self::Utf8String(s) => s.as_ref(), | ||
| // TODO(dishmaker): BMPString as ref | ||
| Self::BmpString(_s) => "", |
There was a problem hiding this comment.
as_ref can't be deprecated
There was a problem hiding this comment.
Could maybe use Cow<str> here, though that would need a different method name.
Another option is to transcode while decoding.
There was a problem hiding this comment.
Looks like it was used before as
<_ as AsRef<str>>::as_ref(&value)x509-cert: use alloc instead of std x509-cert: apply clippy Cow<'_, str> x509-cert: fix test decode_cert_bmpstring
dishmaker
force-pushed
the
dishmaker/x509_cert_add_bmpstring
branch
from
25f4c88 to
3c1a63c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1792
Depends on: