Skip to content

HIGHT Cipher #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

HIGHT Cipher #471

wants to merge 13 commits into from

Conversation

Arul-Sujith
Copy link

  • Includes encryption and decryption functions.
  • Tested using sample vectors to ensure correctness.
  • Added Docs

Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not accept implementation of the cipher in such form. Please properly follow example of other crates in this repository.

@Arul-Sujith
Copy link
Author

Thanks for the feedback! I’ve reviewed the structure of other implementations in the repository. I’ll restructure and update the PR soon. Let me know if there are any specific guidelines I should follow!

Copy link
Author

@Arul-Sujith Arul-Sujith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Made:

  • Restructured the implementation to match the format used in other crates in this repository.

Please let me know if anything else needs adjustment or if there are further guidelines to follow.

@Arul-Sujith Arul-Sujith requested a review from newpavlov March 9, 2025 16:29
@newpavlov
Copy link
Member

newpavlov commented Mar 10, 2025

You haven't matched the format of other block cipher crates. At the very least you have to implement the cipher traits. The docs folder is also not necessary a link to the HIGHT paper in crate docs will be sufficient.

You also need to add a CI config for the crate and add it to the workspace (see the root Cargo.toml).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants