Skip to content

Conversation

hoxxep
Copy link

@hoxxep hoxxep commented Aug 13, 2025

Small usability PR. Using x-wing otherwise requires importing the kem crate directly (and syncing versions).

@newpavlov
Copy link
Member

It's probably worth to re-export kem as well, i.e. to write pub use kem::{self, Decapsulate, Encapsulate};.

@hoxxep
Copy link
Author

hoxxep commented Aug 13, 2025

Very happy to add it in! What else are you aiming to expose in particular, or is this mostly for future-proofing?

If it's for exporting CryptoRng, perhaps it's also worth also exporting RngCore from kem to be able to (re)implement CryptoRng from a different version of rand? I can add that into this PR too if useful?

@newpavlov
Copy link
Member

I think rand_core should be re-exported from kem, not from implementation crates.

@hoxxep
Copy link
Author

hoxxep commented Aug 13, 2025

Ah sorry – just realising traits is an entirely separate repo. Ignore the same PR comment.

@hoxxep hoxxep force-pushed the x-wing-expose-capsulation-traits branch from cc252a6 to a9b4c91 Compare August 13, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants