Use associated types instead of magical names in platform_impl #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the exported surface area of each host implementation, and makes the impl_platform_host macro more robust.
|
Nice improvement for robustness and maintainability. Thank you, merging. |
roderickvd
pushed a commit
to roderickvd/cpal
that referenced
this pull request
Aug 30, 2025
…udio#1004) This reduces the exported surface area of each host implementation, and makes the impl_platform_host macro more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the exported surface area of each host implementation, and makes the
impl_platform_hostmacro more robust.This was originally part of #957, but it was requested that I pull it out.