Merge pull request #50 from Rust-for-Linux/ci-fix

fix various mistakes in the CI

Author: BennoLossin

.github/workflows/ci.yml

@@ -15,8 +15,7 @@ jobs:
         with:
           components: rustfmt
       - run: git config user.name "github-runner" && git config user.email "<>"
-      - run: git rebase --exec 'cargo fmt --check' --root
-      - run: git rebase --exec 'cd internal && cargo fmt --check' --root
+      - run: git rebase --exec 'cargo fmt --check --all' --root
   readme:
     runs-on: ubuntu-latest
     steps:
@@ -40,7 +39,9 @@ jobs:
         with:
           components: rust-src
       - run: git config user.name "github-runner" && git config user.email "<>"
-      - run: git rebase --exec 'cargo doc --no-deps' --root
+      - run: git rebase --exec 'cargo doc --all-features --no-deps' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
   clippy:
     runs-on: ubuntu-latest
     steps:
@@ -53,7 +54,14 @@ jobs:
           components: clippy
       - run: cargo install cargo-hack
       - run: git config user.name "github-runner" && git config user.email "<>"
-      - run: git rebase --exec 'cargo hack --clean-per-run --feature-powerset clippy --locked' --exec 'cargo clean' --root
+      # examples and tests require `alloc`, since they make extensive use of `Box` etc.
+      - run: git rebase --exec 'cargo hack --clean-per-run --feature-powerset clippy --all-targets --locked --features alloc' --exec 'cargo clean' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
+      # the core lib does not, so also check that without the alloc feature.
+      - run: git rebase --exec 'cargo hack --clean-per-run --feature-powerset clippy --lib --locked' --exec 'cargo clean' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
   test:
     runs-on: ubuntu-latest
     steps:
@@ -63,10 +71,19 @@ jobs:
           components: rust-src
       - run: cargo install cargo-expand
       - run: git config user.name "github-runner" && git config user.email "<>"
-      - run: git rebase --exec 'cargo test --locked' --root
+      - run: git rebase --exec 'cargo test --locked --all-targets' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
+      # doctests are strangely not included in --all-targets
+      - run: git rebase --exec 'cargo test --locked --doc' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
   miri:
     runs-on: ubuntu-latest
-    name: "miri"
+    name: "miri (${{matrix.MIRIFLAGS}})"
+    strategy:
+      matrix:
+        MIRIFLAGS: ["", "-Zmiri-tree-borrows", "-Zmiri-strict-provenance", "-Zmiri-tree-borrows -Zmiri-strict-provenance"]
     steps:
       - uses: actions/checkout@v4
         with:
@@ -81,18 +98,20 @@ jobs:
           components: miri, rust-src
       - run: cargo install cargo-expand
       - run: git config user.name "github-runner" && git config user.email "<>"
-      - run: git rebase --exec 'cargo miri test --locked' --root
-      - run: git rebase --exec 'cargo miri test --locked' --root
+      - run: git rebase --exec 'cargo miri test --locked --all-targets' --root
         env:
-          MIRIFLAGS: "-Zmiri-tree-borrows"
-      - run: git rebase --exec 'cargo miri test --locked' --root
+          RUSTFLAGS: "-Dwarnings"
+          MIRIFLAGS: ${{matrix.MIRIFLAGS}}
+      # doctests are strangely not included in --all-targets
+      - run: git rebase --exec 'cargo miri test --locked --doc' --root
         env:
-          MIRIFLAGS: "-Zmiri-strict-provenance"
-      - run: git rebase --exec 'cargo miri test --locked' --root
-        env:
-          MIRIFLAGS: "-Zmiri-tree-borrows -Zmiri-strict-provenance"
+          RUSTFLAGS: "-Dwarnings"
+          MIRIFLAGS: ${{matrix.MIRIFLAGS}}
   sanitizers:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        targets: ["--doc", "--all-targets"]
     steps:
       - uses: actions/checkout@v4
         with:
@@ -109,10 +128,20 @@ jobs:
       - run: git rebase --exec "sed -i '/\[features\]/i [profile.dev]' Cargo.toml && sed -i '/profile.dev/a opt-level = 1' Cargo.toml && cargo test --lib --tests --target x86_64-unknown-linux-gnu && git restore Cargo.toml" --root
         env:
           ASAN_OPTIONS: "detect_odr_violation=0:detect_leaks=0"
-          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=address"
-      - run: git rebase --exec 'cargo test --target x86_64-unknown-linux-gnu' --root
+          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=address -Dwarnings"
+      # sed because of https://github.com/japaric/rust-san#unrealiable-leaksanitizer
+      # doctests are strangely not included in --all-targets
+      - run: git rebase --exec "sed -i '/\[features\]/i [profile.dev]' Cargo.toml && sed -i '/profile.dev/a opt-level = 1' Cargo.toml && cargo test --doc --target x86_64-unknown-linux-gnu && git restore Cargo.toml" --root
+        env:
+          ASAN_OPTIONS: "detect_odr_violation=0:detect_leaks=0"
+          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=address -Dwarnings"
+      - run: git rebase --exec 'cargo test --all-targets --target x86_64-unknown-linux-gnu' --root
+        env:
+          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=leak -Dwarnings"
+      # doctests are strangely not included in --all-targets
+      - run: git rebase --exec 'cargo test --doc --target x86_64-unknown-linux-gnu' --root
         env:
-          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=leak"
+          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=leak -Dwarnings"
   msrv:
     runs-on: ubuntu-latest
     steps:
@@ -123,7 +152,9 @@ jobs:
       - uses: dtolnay/rust-toolchain@stable
       - run: cargo install cargo-hack
       - run: git config user.name "github-runner" && git config user.email "<>"
-      - run: git rebase --exec 'cargo hack --clean-per-run --feature-powerset --exclude-features alloc --exclude-features default --version-range 1.82.. --clean-per-version check --locked' --exec 'cargo clean' --root
+      - run: git rebase --exec 'cargo hack --clean-per-run --feature-powerset --exclude-features alloc --exclude-features default --version-range 1.82.. --clean-per-version check --locked --all-targets' --exec 'cargo clean' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
   nightly-msrv:
     runs-on: ubuntu-latest
     steps:
@@ -137,9 +168,10 @@ jobs:
       - run: cargo install cargo-hack
       - run: cargo install cargo-expand
       - run: git config user.name "github-runner" && git config user.email "<>"
-      - run: git rebase --exec 'cargo hack --clean-per-run --feature-powerset --version-range 1.78.. --clean-per-version check --locked' --exec 'cargo clean' --root
+      - run: git rebase --exec 'cargo hack --clean-per-run --feature-powerset --version-range 1.78.. --clean-per-version check --locked --all-targets' --exec 'cargo clean' --root
         env:
           RUSTC_BOOTSTRAP: 1
+          RUSTFLAGS: "-Dwarnings"
   os-check:
     strategy:
       fail-fast: false
@@ -157,7 +189,13 @@ jobs:
           components: rust-src
       - run: cargo install cargo-expand
       - run: git config user.name "github-runner" && git config user.email "<>"
-      - run: git rebase --exec 'cargo test --locked' --root
+      - run: git rebase --exec 'cargo test --all-targets --locked' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
+      # doctests are strangely not included in --all-targets
+      - run: git rebase --exec 'cargo test --doc --locked' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
   signed-off-by:
     runs-on: ubuntu-latest
     steps:
@@ -208,4 +246,6 @@ jobs:
           components: rust-src
       - run: sudo apt-get install -y linkchecker
       - run: git config user.name "github-runner" && git config user.email "<>"
-      - run: git rebase --exec 'cargo doc --no-deps && linkchecker target/doc/*/*.html' --root
+      - run: git rebase --exec 'cargo doc --all-features --no-deps && linkchecker target/doc/*/*.html' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"

.github/workflows/kernel.yml

@@ -0,0 +1,51 @@
+permissions:
+  contents: read
+on:
+  push:
+    branches: [kernel, next]
+  schedule:
+    - cron: '7 7 * * *'
+name: sync-check
+jobs:
+  torvalds:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: kernel
+          path: pin-init
+      - run: git clone --depth 1 git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
+      - run: |
+          cp -r linux/rust/pin-init .
+          cd pin-init
+          if ! git diff --quiet ; then
+              git diff
+              false
+          fi
+          if [ -n "$(git ls-files --others --exclude-standard)" ]; then
+              git status
+              false
+          fi
+  pin-init-next:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: next
+          path: pin-init
+      - uses: actions/checkout@v4
+        with:
+          repository: "Rust-for-Linux/linux"
+          ref: pin-init-next
+          path: kernel
+      - run:
+          cp -r linux/rust/pin-init .
+          cd pin-init
+          if ! git diff --quiet ; then
+              git diff
+              false
+          fi
+          if [ -n "$(git ls-files --others --exclude-standard)" ]; then
+              git status
+              false
+          fi

.github/workflows/sync.yml

@@ -4,6 +4,7 @@ use pin_init::*;
 
 // Struct with size over 1GiB
 #[derive(Debug)]
+#[allow(dead_code)]
 pub struct BigStruct {
     buf: [u8; 1024 * 1024 * 1024],
     a: u64,
@@ -25,15 +26,18 @@ impl ManagedBuf {
 }
 
 fn main() {
-    // we want to initialize the struct in-place, otherwise we would get a stackoverflow
-    let buf: Box<BigStruct> = Box::init(init!(BigStruct {
-        buf <- zeroed(),
-        a: 7,
-        b: 186,
-        c: 7789,
-        d: 34,
-        managed_buf <- ManagedBuf::new(),
-    }))
-    .unwrap();
-    println!("{}", core::mem::size_of_val(&*buf));
+    #[cfg(any(feature = "std", feature = "alloc"))]
+    {
+        // we want to initialize the struct in-place, otherwise we would get a stackoverflow
+        let buf: Box<BigStruct> = Box::init(init!(BigStruct {
+            buf <- zeroed(),
+            a: 7,
+            b: 186,
+            c: 7789,
+            d: 34,
+            managed_buf <- ManagedBuf::new(),
+        }))
+        .unwrap();
+        println!("{}", core::mem::size_of_val(&*buf));
+    }
 }

examples/big_struct_in_place.rs

@@ -14,8 +14,9 @@ use core::{
 
 use pin_init::*;
 
-#[expect(unused_attributes)]
+#[allow(unused_attributes)]
 mod error;
+#[allow(unused_imports)]
 use error::Error;
 
 #[pin_data(PinnedDrop)]
@@ -39,6 +40,7 @@ impl ListHead {
     }
 
     #[inline]
+    #[allow(dead_code)]
     pub fn insert_next(list: &ListHead) -> impl PinInit<Self, Infallible> + '_ {
         try_pin_init!(&this in Self {
             prev: list.next.prev().replace(unsafe { Link::new_unchecked(this)}),
@@ -112,6 +114,7 @@ impl Link {
     }
 
     #[inline]
+    #[allow(dead_code)]
     fn prev(&self) -> &Link {
         unsafe { &(*self.0.get().as_ptr()).prev }
     }
@@ -137,8 +140,13 @@ impl Link {
     }
 }
 
+#[allow(dead_code)]
+#[cfg(not(any(feature = "std", feature = "alloc")))]
+fn main() {}
+
 #[allow(dead_code)]
 #[cfg_attr(test, test)]
+#[cfg(any(feature = "std", feature = "alloc"))]
 fn main() -> Result<(), Error> {
     let a = Box::pin_init(ListHead::new())?;
     stack_pin_init!(let b = ListHead::insert_next(&a));