ci: deny warnings

Signed-off-by: Benno Lossin <[email protected]>

Author: BennoLossin

.github/workflows/ci.yml

@@ -40,6 +40,8 @@ jobs:
           components: rust-src
       - run: git config user.name "github-runner" && git config user.email "<>"
       - run: git rebase --exec 'cargo doc --all-features --no-deps' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
   clippy:
     runs-on: ubuntu-latest
     steps:
@@ -54,8 +56,12 @@ jobs:
       - run: git config user.name "github-runner" && git config user.email "<>"
       # examples and tests require `alloc`, since they make extensive use of `Box` etc.
       - run: git rebase --exec 'cargo hack --clean-per-run --feature-powerset clippy --all-targets --locked --features alloc' --exec 'cargo clean' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
       # the core lib does not, so also check that without the alloc feature.
       - run: git rebase --exec 'cargo hack --clean-per-run --feature-powerset clippy --lib --locked' --exec 'cargo clean' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
   test:
     runs-on: ubuntu-latest
     steps:
@@ -66,8 +72,12 @@ jobs:
       - run: cargo install cargo-expand
       - run: git config user.name "github-runner" && git config user.email "<>"
       - run: git rebase --exec 'cargo test --locked --all-targets' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
       # doctests are strangely not included in --all-targets
       - run: git rebase --exec 'cargo test --locked --doc' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
   miri:
     runs-on: ubuntu-latest
     name: "miri (${{matrix.MIRIFLAGS}})"
@@ -90,10 +100,12 @@ jobs:
       - run: git config user.name "github-runner" && git config user.email "<>"
       - run: git rebase --exec 'cargo miri test --locked --all-targets' --root
         env:
+          RUSTFLAGS: "-Dwarnings"
           MIRIFLAGS: ${{matrix.MIRIFLAGS}}
       # doctests are strangely not included in --all-targets
       - run: git rebase --exec 'cargo miri test --locked --doc' --root
         env:
+          RUSTFLAGS: "-Dwarnings"
           MIRIFLAGS: ${{matrix.MIRIFLAGS}}
   sanitizers:
     runs-on: ubuntu-latest
@@ -116,20 +128,20 @@ jobs:
       - run: git rebase --exec "sed -i '/\[features\]/i [profile.dev]' Cargo.toml && sed -i '/profile.dev/a opt-level = 1' Cargo.toml && cargo test --lib --tests --target x86_64-unknown-linux-gnu && git restore Cargo.toml" --root
         env:
           ASAN_OPTIONS: "detect_odr_violation=0:detect_leaks=0"
-          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=address"
+          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=address -Dwarnings"
       # sed because of https://github.com/japaric/rust-san#unrealiable-leaksanitizer
       # doctests are strangely not included in --all-targets
       - run: git rebase --exec "sed -i '/\[features\]/i [profile.dev]' Cargo.toml && sed -i '/profile.dev/a opt-level = 1' Cargo.toml && cargo test --doc --target x86_64-unknown-linux-gnu && git restore Cargo.toml" --root
         env:
           ASAN_OPTIONS: "detect_odr_violation=0:detect_leaks=0"
-          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=address"
+          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=address -Dwarnings"
       - run: git rebase --exec 'cargo test --all-targets --target x86_64-unknown-linux-gnu' --root
         env:
-          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=leak"
+          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=leak -Dwarnings"
       # doctests are strangely not included in --all-targets
       - run: git rebase --exec 'cargo test --doc --target x86_64-unknown-linux-gnu' --root
         env:
-          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=leak"
+          RUSTFLAGS: "--cfg NO_UI_TESTS --cfg NO_ALLOC_FAIL_TESTS -Z sanitizer=leak -Dwarnings"
   msrv:
     runs-on: ubuntu-latest
     steps:
@@ -141,6 +153,8 @@ jobs:
       - run: cargo install cargo-hack
       - run: git config user.name "github-runner" && git config user.email "<>"
       - run: git rebase --exec 'cargo hack --clean-per-run --feature-powerset --exclude-features alloc --exclude-features default --version-range 1.82.. --clean-per-version check --locked --all-targets' --exec 'cargo clean' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
   nightly-msrv:
     runs-on: ubuntu-latest
     steps:
@@ -157,6 +171,7 @@ jobs:
       - run: git rebase --exec 'cargo hack --clean-per-run --feature-powerset --version-range 1.78.. --clean-per-version check --locked --all-targets' --exec 'cargo clean' --root
         env:
           RUSTC_BOOTSTRAP: 1
+          RUSTFLAGS: "-Dwarnings"
   os-check:
     strategy:
       fail-fast: false
@@ -175,8 +190,12 @@ jobs:
       - run: cargo install cargo-expand
       - run: git config user.name "github-runner" && git config user.email "<>"
       - run: git rebase --exec 'cargo test --all-targets --locked' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
       # doctests are strangely not included in --all-targets
       - run: git rebase --exec 'cargo test --doc --locked' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"
   signed-off-by:
     runs-on: ubuntu-latest
     steps:
@@ -228,3 +247,5 @@ jobs:
       - run: sudo apt-get install -y linkchecker
       - run: git config user.name "github-runner" && git config user.email "<>"
       - run: git rebase --exec 'cargo doc --all-features --no-deps && linkchecker target/doc/*/*.html' --root
+        env:
+          RUSTFLAGS: "-Dwarnings"