Skip to content

feat: Symphony as Encore Feature + multi-URL registry support #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedramamini wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Symphony as Encore Feature + multi-URL registry support #516

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dddf781
feat: gate Maestro Symphony behind Encore Features toggle, add multi-…
pedramamini Mar 4, 2026
382f712
merge: resolve conflicts with main, adapt encore features to decompos…
pedramamini Mar 4, 2026
222e201
fix: address CodeRabbit PR review findings for encore-features
pedramamini Mar 4, 2026
8910615
refactor: move Usage & Stats settings from General tab to Encore Feat…
pedramamini Mar 6, 2026
5092e46
docs: move Usage Dashboard and Maestro Symphony under Encore Features…
pedramamini Mar 6, 2026
debe883
refactor: reorder Encore Features, remove BETA from Usage Dashboard
pedramamini Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/__tests__/renderer/components/Settings/tabs/EncoreTab.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ vi.mock('../../../../../renderer/components/Wizard/screens/AgentSelectionScreen'
// Shared mock fns for useSettings setters
const mockSetEncoreFeatures = vi.fn();
const mockSetDirectorNotesSettings = vi.fn();
const mockSetStatsCollectionEnabled = vi.fn();
const mockSetDefaultStatsTimeRange = vi.fn();
const mockSetWakatimeEnabled = vi.fn();
const mockSetWakatimeApiKey = vi.fn();
const mockSetWakatimeDetailedTracking = vi.fn();

// Override mechanism for per-test customization
let mockUseSettingsOverrides: Record<string, any> = {};
Expand All @@ -100,6 +105,21 @@ vi.mock('../../../../../renderer/hooks/settings/useSettings', () => ({
defaultLookbackDays: 7,
},
setDirectorNotesSettings: mockSetDirectorNotesSettings,
// Stats
statsCollectionEnabled: true,
setStatsCollectionEnabled: mockSetStatsCollectionEnabled,
defaultStatsTimeRange: 'week',
setDefaultStatsTimeRange: mockSetDefaultStatsTimeRange,
// WakaTime
wakatimeEnabled: false,
setWakatimeEnabled: mockSetWakatimeEnabled,
wakatimeApiKey: '',
setWakatimeApiKey: mockSetWakatimeApiKey,
wakatimeDetailedTracking: false,
setWakatimeDetailedTracking: mockSetWakatimeDetailedTracking,
// Symphony
symphonyRegistryUrls: [],
setSymphonyRegistryUrls: vi.fn(),
...mockUseSettingsOverrides,
}),
}));
Expand Down Expand Up @@ -170,6 +190,10 @@ describe('EncoreTab', () => {
vi.mocked(window.maestro.agents.getConfig).mockResolvedValue({});
vi.mocked(window.maestro.agents.setConfig).mockResolvedValue(undefined);
vi.mocked(window.maestro.agents.getModels).mockResolvedValue([]);
vi.mocked(window.maestro.stats.getDatabaseSize).mockResolvedValue(1024 * 1024);
vi.mocked(window.maestro.stats.getEarliestTimestamp).mockResolvedValue(null);
vi.mocked(window.maestro.wakatime.checkCli).mockResolvedValue({ available: false });
vi.mocked(window.maestro.wakatime.validateApiKey).mockResolvedValue({ valid: false });
});

afterEach(() => {
Expand Down
295 changes: 1 addition & 294 deletions src/__tests__/renderer/components/Settings/tabs/GeneralTab.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
* - Rendering options (GPU acceleration, confetti)
* - Update settings (check on startup, beta updates)
* - Crash reporting toggle
* - Stats collection toggle and time range selector
* - WakaTime integration (toggle, API key, detailed tracking, CLI check)
* - Storage location display
*/

Expand Down Expand Up @@ -53,11 +51,6 @@ const mockSetDisableConfetti = vi.fn();
const mockSetCheckForUpdatesOnStartup = vi.fn();
const mockSetEnableBetaUpdates = vi.fn();
const mockSetCrashReportingEnabled = vi.fn();
const mockSetStatsCollectionEnabled = vi.fn();
const mockSetDefaultStatsTimeRange = vi.fn();
const mockSetWakatimeEnabled = vi.fn();
const mockSetWakatimeApiKey = vi.fn();
const mockSetWakatimeDetailedTracking = vi.fn();

// Allow per-test overrides of settings
let mockUseSettingsOverrides: Record<string, any> = {};
Expand Down Expand Up @@ -109,18 +102,6 @@ vi.mock('../../../../../renderer/hooks/settings/useSettings', () => ({
setEnableBetaUpdates: mockSetEnableBetaUpdates,
crashReportingEnabled: true,
setCrashReportingEnabled: mockSetCrashReportingEnabled,
// Stats
statsCollectionEnabled: true,
setStatsCollectionEnabled: mockSetStatsCollectionEnabled,
defaultStatsTimeRange: 'week',
setDefaultStatsTimeRange: mockSetDefaultStatsTimeRange,
// WakaTime
wakatimeEnabled: false,
setWakatimeEnabled: mockSetWakatimeEnabled,
wakatimeApiKey: '',
setWakatimeApiKey: mockSetWakatimeApiKey,
wakatimeDetailedTracking: false,
setWakatimeDetailedTracking: mockSetWakatimeDetailedTracking,
...mockUseSettingsOverrides,
}),
}));
Expand Down Expand Up @@ -158,10 +139,6 @@ describe('GeneralTab', () => {

// Reset window.maestro mocks
vi.mocked(window.maestro.shells.detect).mockResolvedValue(mockShells);
vi.mocked(window.maestro.wakatime.checkCli).mockResolvedValue({ available: false });
vi.mocked(window.maestro.wakatime.validateApiKey).mockResolvedValue({ valid: false });
vi.mocked(window.maestro.stats.getDatabaseSize).mockResolvedValue(1024 * 1024);
vi.mocked(window.maestro.stats.getEarliestTimestamp).mockResolvedValue(null);
vi.mocked(window.maestro.sync.getDefaultPath).mockResolvedValue('/default/path');
vi.mocked(window.maestro.sync.getSettings).mockResolvedValue({
customSyncPath: undefined,
Expand Down Expand Up @@ -200,7 +177,6 @@ describe('GeneralTab', () => {
expect(screen.getByText('Updates')).toBeInTheDocument();
expect(screen.getByText('Pre-release Channel')).toBeInTheDocument();
expect(screen.getByText('Privacy')).toBeInTheDocument();
expect(screen.getByText('Usage & Stats')).toBeInTheDocument();
expect(screen.getByText('Storage Location')).toBeInTheDocument();
});

Expand All @@ -212,9 +188,8 @@ describe('GeneralTab', () => {
});

// The component still renders its JSX, but effects that fetch data won't fire
// Verify the sync/stats load effects didn't run
// Verify the sync load effects didn't run
expect(window.maestro.sync.getDefaultPath).not.toHaveBeenCalled();
expect(window.maestro.stats.getDatabaseSize).not.toHaveBeenCalled();
});
});

Expand Down Expand Up @@ -1319,274 +1294,6 @@ describe('GeneralTab', () => {
});
});

// =========================================================================
// 18. WakaTime
// =========================================================================
describe('WakaTime', () => {
it('should render WakaTime enable toggle', async () => {
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(screen.getByText('Enable WakaTime tracking')).toBeInTheDocument();
});

it('should call setWakatimeEnabled when toggle is clicked', async () => {
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

// The WakaTime toggle is a standalone switch (not wrapped in SettingCheckbox).
// Find it via aria-checked attribute on the WakaTime section's switch.
// Since wakatimeEnabled is false by default, find the switch with aria-checked=false
// that is adjacent to the WakaTime label.
const titleElement = screen.getByText('Enable WakaTime tracking');
// Walk up from <p> -> <div> -> <div class="flex items-center justify-between">
const outerContainer = titleElement.parentElement?.parentElement;
const toggleSwitch = outerContainer?.querySelector('button[role="switch"]');

fireEvent.click(toggleSwitch!);
expect(mockSetWakatimeEnabled).toHaveBeenCalledWith(true);
});

it('should show API key input when WakaTime is enabled', async () => {
mockUseSettingsOverrides = { wakatimeEnabled: true };
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(screen.getByPlaceholderText('waka_...')).toBeInTheDocument();
});

it('should not show API key input when WakaTime is disabled', async () => {
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(screen.queryByPlaceholderText('waka_...')).not.toBeInTheDocument();
});

it('should call setWakatimeApiKey when API key input changes', async () => {
mockUseSettingsOverrides = { wakatimeEnabled: true };
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

const apiKeyInput = screen.getByPlaceholderText('waka_...');
fireEvent.change(apiKeyInput, { target: { value: 'waka_test123' } });

expect(mockSetWakatimeApiKey).toHaveBeenCalledWith('waka_test123');
});

it('should show detailed tracking toggle when WakaTime is enabled', async () => {
mockUseSettingsOverrides = { wakatimeEnabled: true };
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(screen.getByText('Detailed file tracking')).toBeInTheDocument();
});

it('should call setWakatimeDetailedTracking when toggle is clicked', async () => {
mockUseSettingsOverrides = { wakatimeEnabled: true };
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

const titleElement = screen.getByText('Detailed file tracking');
const parentDiv = titleElement.closest('.flex');
const toggleSwitch = parentDiv?.querySelector('button[role="switch"]');

fireEvent.click(toggleSwitch!);
expect(mockSetWakatimeDetailedTracking).toHaveBeenCalledWith(true);
});

it('should check WakaTime CLI when enabled and modal is open', async () => {
mockUseSettingsOverrides = { wakatimeEnabled: true };
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(window.maestro.wakatime.checkCli).toHaveBeenCalled();
});

it('should not check WakaTime CLI when disabled', async () => {
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(window.maestro.wakatime.checkCli).not.toHaveBeenCalled();
});

it('should show CLI installing message when CLI is not available', async () => {
mockUseSettingsOverrides = { wakatimeEnabled: true };
vi.mocked(window.maestro.wakatime.checkCli).mockResolvedValue({ available: false });

render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(
screen.getByText('WakaTime CLI is being installed automatically...')
).toBeInTheDocument();
});

it('should not show CLI installing message when CLI is available', async () => {
mockUseSettingsOverrides = { wakatimeEnabled: true };
vi.mocked(window.maestro.wakatime.checkCli).mockResolvedValue({
available: true,
version: '1.0.0',
});

render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(
screen.queryByText('WakaTime CLI is being installed automatically...')
).not.toBeInTheDocument();
});

it('should validate API key on blur', async () => {
mockUseSettingsOverrides = {
wakatimeEnabled: true,
wakatimeApiKey: 'waka_test123',
};
vi.mocked(window.maestro.wakatime.validateApiKey).mockResolvedValue({ valid: true });

render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

const apiKeyInput = screen.getByPlaceholderText('waka_...');
fireEvent.blur(apiKeyInput);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(window.maestro.wakatime.validateApiKey).toHaveBeenCalledWith('waka_test123');
});
});

// =========================================================================
// 19. Stats Collection
// =========================================================================
describe('Stats Collection', () => {
it('should render stats collection toggle', async () => {
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(screen.getByText('Enable stats collection')).toBeInTheDocument();
});

it('should call setStatsCollectionEnabled when toggle is clicked', async () => {
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

const titleElement = screen.getByText('Enable stats collection');
const parentDiv = titleElement.closest('.flex');
const toggleSwitch = parentDiv?.querySelector('button[role="switch"]');

fireEvent.click(toggleSwitch!);
expect(mockSetStatsCollectionEnabled).toHaveBeenCalledWith(false);
});

it('should render time range select', async () => {
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(screen.getByText('Default dashboard time range')).toBeInTheDocument();
const select = screen.getByDisplayValue('Last 7 days') as HTMLSelectElement;
expect(select).toBeInTheDocument();
});

it('should call setDefaultStatsTimeRange when time range is changed', async () => {
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

const select = screen.getByDisplayValue('Last 7 days');
fireEvent.change(select, { target: { value: 'month' } });

expect(mockSetDefaultStatsTimeRange).toHaveBeenCalledWith('month');
});

it('should show all time range options', async () => {
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(screen.getByText('Last 24 hours')).toBeInTheDocument();
expect(screen.getByText('Last 7 days')).toBeInTheDocument();
expect(screen.getByText('Last 30 days')).toBeInTheDocument();
expect(screen.getByText('Last 365 days')).toBeInTheDocument();
expect(screen.getByText('All time')).toBeInTheDocument();
});

it('should display database size', async () => {
render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(screen.getByText('Database size')).toBeInTheDocument();
// 1024*1024 bytes = 1.00 MB
expect(screen.getByText(/1\.00 MB/)).toBeInTheDocument();
});

it('should display Loading... when stats size is not yet loaded', async () => {
vi.mocked(window.maestro.stats.getDatabaseSize).mockImplementation(
() => new Promise(() => {}) // never resolves
);

render(<GeneralTab theme={mockTheme} isOpen={true} />);

await act(async () => {
await vi.advanceTimersByTimeAsync(100);
});

expect(screen.getByText('Loading...')).toBeInTheDocument();
});
});

// =========================================================================
// 20. Shell Detection Failure
Expand Down
Loading