Skip to content

[Feat/add-sort-options] - 기록조회 옵션 추가#92

Merged
ekgns33 merged 1 commit intomainfrom
feat/add-sort-by
May 13, 2025
Merged

[Feat/add-sort-options] - 기록조회 옵션 추가#92
ekgns33 merged 1 commit intomainfrom
feat/add-sort-by

Conversation

@ekgns33
Copy link
Contributor

@ekgns33 ekgns33 commented May 12, 2025

작업내역

  • createdAt, endAt 기준 정렬 옵션 추가
  • 정렬 기준 asc, desc

Summary by CodeRabbit

  • New Features
    • Added support for sorting records by selectable fields and direction when viewing your records.
  • Refactor
    • Improved the flexibility of record queries and sorting options for a more customizable user experience.

@ekgns33 ekgns33 requested a review from jeeheaG May 12, 2025 10:03
@ekgns33 ekgns33 self-assigned this May 12, 2025
@coderabbitai
Copy link

coderabbitai bot commented May 12, 2025

Walkthrough

Sorting functionality was added to the record listing feature by introducing sortBy and sortDirection fields to the request and query objects. The builder pattern was adopted for constructing queries. The repository query no longer enforces a default order, allowing dynamic sorting based on the new parameters.

Changes

File(s) Change Summary
src/main/java/org/runimo/runimo/records/controller/request/MyRecordPageRequest.java Added sortBy and sortDirection fields with Swagger annotations; updated toQuery to use builder.
src/main/java/org/runimo/runimo/records/service/dto/RecordQuery.java Introduced sortBy and sortDirection fields; added Lombok @Builder; updated toPageable for sorting.
src/main/java/org/runimo/runimo/records/repository/RecordRepository.java Removed ORDER BY clause from the query in findRecordByUserIdAndBetween.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Controller
    participant Service
    participant Repository

    Client->>Controller: Sends MyRecordPageRequest (with sortBy, sortDirection)
    Controller->>Service: Converts request to RecordQuery (using builder)
    Service->>Repository: Calls findRecordByUserIdAndBetween with RecordQuery
    Repository-->>Service: Returns records (no default order)
    Service-->>Controller: Returns sorted records based on query parameters
    Controller-->>Client: Responds with sorted records
Loading

Poem

In the warren of records, a new breeze flows,
With sorting by fields, as the query now knows.
Builder hops in, with direction and flair,
The old order’s gone, now sorting’s in the air!
Records align, in asc or desc delight,
A bunny’s code hops—oh, what a sight!
🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 52791c5 and 0db38b0.

📒 Files selected for processing (3)
  • src/main/java/org/runimo/runimo/records/controller/request/MyRecordPageRequest.java (1 hunks)
  • src/main/java/org/runimo/runimo/records/repository/RecordRepository.java (1 hunks)
  • src/main/java/org/runimo/runimo/records/service/dto/RecordQuery.java (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@jeeheaG jeeheaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 !

@ekgns33 ekgns33 merged commit f65a358 into main May 13, 2025
3 checks passed
@ekgns33 ekgns33 deleted the feat/add-sort-by branch May 13, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants