-
Notifications
You must be signed in to change notification settings - Fork 18
Add Two Struct Objects #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robskrob
wants to merge
4
commits into
RubyoffRails:master
Choose a base branch
from
robskrob:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| Passenger = Struct.new(:name) | ||
| Train = Struct.new(:destination, :number_of_cars, :caboose, :number_of_engine) | ||
|
|
||
| passengers = [Passenger.new(name: 'Bill Smith'), Passenger.new(name: 'Sarah Robot')] | ||
| train = Train.new( passengers, {destination: 'New York', number_of_engines: 4, caboose: true, number_of_cars: 5}) | ||
|
|
||
| puts "Destination: #{train.destination}" | ||
| puts "Cars: #{train.number_of_cars}" | ||
| puts "Caboose: #{train.caboose}" | ||
| puts "Passengers: #{passengers}" | ||
| puts "Engines: #{train.number_of_engines}" | ||
|
|
||
|
|
||
|
|
||
| =begin | ||
| puts 'train specifications:' | ||
| description.each do |key, value| | ||
| puts "#{key}: #{value}" | ||
| end | ||
|
|
||
| puts 'train destination:' | ||
| destination.each do |key, value| | ||
| puts "#{key}: #{value}" | ||
| end | ||
|
|
||
| puts 'Passenger\'s name' | ||
| bill.name.each do |key, value| | ||
| puts "#{key}: #{value}" | ||
| end | ||
|
|
||
| puts 'Bill\'s destination' | ||
| bill.destination.each do |key, value| | ||
| puts "#{key}: #{value}" | ||
| end | ||
|
|
||
| puts 'Bill\'s train specifications' | ||
| bill.description.each do |key, value| | ||
| puts "#{key}: #{value}" | ||
| end | ||
| =end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this output? Is it what you would expect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works except: puts "Engines: #{train.number_of_engines}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output is the following:
$ ruby train.rb
Destination: [#<struct Passenger name={:name=>"Bill Smith"}>, #<struct Passenger name={:name=>"Sarah Robot"}>]
Cars: {:destination=>"New York", :number_of_engines=>4, :caboose=>true, :number_of_cars=>5}
Caboose:
Passengers: [#<struct Passenger name={:name=>"Bill Smith"}>, #<struct Passenger name={:name=>"Sarah Robot"}>]
train.rb:11:in
<main>': undefined methodnumber_of_engines' for #Train:0x007fb9311a86b8 (NoMethodError)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, the destination seems wrong, as well as Cars, Caboose, and Passengers.
If your definition for train is
Struct.new(:destination, :number_of_cars, :caboose, :number_of_engine)then what are you sending in?There isn't a place for passengers.
And to simplify things, let's change
to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps I should watch the video again...it is not clear to me what should
be a hash vs a Struct and how to construct it the way you want it. I will
start over again.
On Tue, Jan 14, 2014 at 12:46 PM, Jesse Wolgamott
notifications@github.comwrote:
Robert Jewell
1.914.400.5219