-
Notifications
You must be signed in to change notification settings - Fork 22
pandas and tigers #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ellesuzuki
wants to merge
2
commits into
RubyoffRails:master
Choose a base branch
from
ellesuzuki:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| require_relative './vehicle' | ||
|
|
||
| class Auto < Vehicle | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| require_relative './vehicle' | ||
|
|
||
| class Moto < Vehicle | ||
| def self.wheels | ||
| 2 | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| class Vehicle | ||
| attr_accessor :color, :make, :model, :year | ||
|
|
||
| def initialize(options = {color: nil, make: nil, model: nil, year: nil}) | ||
| @color = options.fetch(:color) | ||
| @make = options.fetch(:make) | ||
| @model = options.fetch(:model) | ||
| @year = options.fetch(:year) | ||
| end | ||
|
|
||
| def self.wheels | ||
| 4 | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| require_relative '../models/auto' | ||
|
|
||
| describe Auto do | ||
| before(:each) do | ||
| @auto = Auto.new | ||
| end | ||
|
|
||
| it "should return number of wheels" do | ||
| Auto.wheels.should eq(4) | ||
| end | ||
|
|
||
| it 'should have color attribute' do | ||
| @auto.should respond_to(:color) | ||
| end | ||
|
|
||
| it 'should have make attribute' do | ||
| @auto.should respond_to(:make) | ||
| end | ||
|
|
||
| it 'should have model attribute' do | ||
| @auto.should respond_to(:model) | ||
| end | ||
|
|
||
| it 'should have year attribute' do | ||
| @auto.should respond_to(:year) | ||
| end | ||
|
|
||
| it 'should accept a hash of info to update variables' do | ||
| auto = Auto.new(options = {:color => 'black', :make => 'Volkswagen', :model => 'Golf', :year => 2012}) | ||
| auto.make.should eq('Volkswagen') | ||
| end | ||
|
|
||
| it 'should inherit from vehicle' do | ||
| @auto.is_a?(Vehicle).should be_true | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. some RSpec magic here, you could write: @auto.should be_a(Vehicle) |
||
| end | ||
|
|
||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| require_relative '../models/moto' | ||
|
|
||
| describe Moto do | ||
|
|
||
| before(:each) do | ||
| @moto = Moto.new | ||
| end | ||
|
|
||
| it 'should inherit from Vehicle' do | ||
| @moto.is_a?(Vehicle).should be_true | ||
| end | ||
|
|
||
| it 'should have 2 tires' do | ||
| Moto.wheels.should eq(2) | ||
| end | ||
|
|
||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| require_relative '../models/vehicle' | ||
|
|
||
| describe Vehicle do | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally here, you wouldn't bother assigning the hash to "options" just to send in to Auto. You could write it as:
And ruby also allows:
Those will all get munged into a single hash variable. Finally, I really like this syntax better (the 1.9 hash syntax), but this is an aesthetic and team choice: