Skip to content

Panda - fix search results to not throw an error if movie not found #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jperezish wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Panda - fix search results to not throw an error if movie not found #25

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83a9562
fix search results to not throw an error if movie not found
jperezish Feb 1, 2014
6243578
update no results method to return a NotFoundMovie object
jperezish Feb 4, 2014
125667b
update title not found spec with mock api
jperezish Feb 4, 2014
0f4b354
add the average rating score for a group of movies
jperezish Feb 5, 2014
fbd0c61
add taste analyzer
jperezish Feb 10, 2014
95e7612
update spec to allow for approximate value, uupdate #movie_score_aver…
jperezish Feb 13, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions lib/api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,21 @@ class Api
def self.search_by_title(title)
url = "http://api.rottentomatoes.com/api/public/v1.0/movies.json?apikey=#{APIKEY}&q=#{URI.encode(title)}&page_limit=1"
struct = OpenStruct.new(get_url_as_json(url).fetch("movies").first)
Movie.new(id: struct.id.to_i,
title: struct.title,
year: struct.year,
score: struct.ratings["critics_score"]
)
if struct.respond_to?(:title)
Copy link
Member

@jwo jwo Feb 3, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting use of respond_to here

Movie.new(id: struct.id.to_i,
title: struct.title,
year: struct.year,
score: struct.ratings["critics_score"]
)
else
Movie.new(id: 0,
Copy link
Member

@jwo jwo Feb 3, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather see a "NullMovie" or "NotFoundMovie" object returned here --- something that you can test for, rather than testing if the movie's id == 0.

But, this works!

If you did the null movie, it could look like

def self.search_by_title(title)
  url = "http://api.rottentomatoes.com/api/public/v1.0/movies.json?apikey=#{APIKEY}&q=#{URI.encode(title)}&page_limit=1"
  build_move get_url_as_json(url).fetch("movies").first
end

def build_movie(json)
  struct = OpenStruct.new(json)
  if json["ratings"]
    Movie.new() # id/title/year
  else
    NotFoundMovie.new
end

title: "no results",
year: "",
score: "N/A"
)
end
end


def self.get_url_as_json(url)
JSON.parse(open(url).read)
end
Expand Down
41 changes: 26 additions & 15 deletions spec/api_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,37 @@
require "ostruct"

describe Api do
describe ".search_by_title" do
context "when title found" do
let(:movie) { Api.search_by_title("Forrest Gump") }

let(:movie) { Api.search_by_title("Forrest Gump") }
before do
Api.stub(:get_url_as_json) { JSON.parse(File.read("spec/fixtures/forrest.json")) }
end

before do
Api.stub(:get_url_as_json) { JSON.parse(File.read("spec/fixtures/forrest.json")) }
end
it "should search for movies" do
movie.title.should eq("Forrest Gump")
end

it "should search for movies" do
movie.title.should eq("Forrest Gump")
end
it "should return the score" do
movie.score.should eq(71)
end

it "should return the score" do
movie.score.should eq(71)
end
it "should return the id" do
movie.id.should eq(10036)
end

it "should return the id" do
movie.id.should eq(10036)
end
it "should return the year" do
movie.year.should eq(1994)
end
end

context "when title not found" do
let(:movie) { Api.search_by_title("asdfasdfasdf") }

it "should return the year" do
movie.year.should eq(1994)
it "should not raise an error" do
movie.title.should_not raise_error
end
end
end
end