Add DLC filter to Cookbooks page#314
Closed
zurillion wants to merge 6 commits intoRoundtableHold:mainfrom
Closed
Conversation
Adds a workflow that runs on every PR and push to main. It installs dependencies, re-runs generate.py, and fails with a clear message if the committed HTML in docs/ differs from what the generator would produce — preventing drift between the YAML source files and the checked-in HTML. https://claude.ai/code/session_01N58bvEvfg7jhcnDJaCpnD5
Instead of failing the PR when HTML is out of sync with YAML, the workflow now runs generate.py and pushes the result back to the PR branch automatically. This makes the workflow safe for agent-authored PRs (Codex, Claude) that may only edit YAML without regenerating the HTML. https://claude.ai/code/session_01N58bvEvfg7jhcnDJaCpnD5
The file was misnamed .gitatttributes (3 t's) so git was never reading it. Renamed to .gitattributes and added linguist-generated attribute for docs/checklists/*.html so GitHub collapses those diffs by default in pull requests. https://claude.ai/code/session_01N58bvEvfg7jhcnDJaCpnD5
…bfkyl2-R7tG0 Claude/review changes mlsgga5of9bfkyl2 r7t g0
Tag the 13 Shadow of the Erdtree cookbook categories with dlc: true at section level (Forager Brood, Igon's, Finger-Weaver's, Greater Potentate's, Ancient Dragon Knight's, Mad Craftsman's, St. Trina Disciple's, Fire Knight's, Loyal Knight's, Battlefield Priest's, Grave Keeper's, Antiquity Scholar's, Tibia's). Add 'cookbooks' to the DLC-aware page set in generate.py so the Show/Base Game/DLC selector is rendered and data-dlc attributes are emitted for every item on the page. Result: 45 DLC items, 59 base game items, all sections are homogeneous so the filter never produces an empty category. https://claude.ai/code/session_01N58bvEvfg7jhcnDJaCpnD5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dlc: trueat section level in
cookbooks.yaml'cookbooks'to the DLC-aware page set ingenerate.py(3occurrences) so the Show / Base Game / DLC selector is rendered
and
data-dlcattributes are emitted on every itemdocs/checklists/cookbooks.htmlWhy section-level tagging
Every cookbook category is 100% base game or 100% DLC — no section
mixes the two. Tagging at section level means the filter never produces
an empty category, and the YAML stays clean without per-item boilerplate.
Result: 45 DLC items across 13 sections, 59 base game items across
8 sections.
DLC sections tagged
Forager Brood · Igon's · Finger-Weaver's · Greater Potentate's ·
Ancient Dragon Knight's · Mad Craftsman's · St. Trina Disciple's ·
Fire Knight's · Loyal Knight's · Battlefield Priest's · Grave Keeper's ·
Antiquity Scholar's · Tibia's
Test plan