Add target="_blank" to attachment download button link
#1383
Conversation
To open download in new browser tab. Opening in current tab breaks the action sidebar
WalkthroughThis pull request introduces a modification to the attachment download functionality in the patient sidebar. The primary change involves adding the Changes
Sequence DiagramsequenceDiagram
participant User
participant Browser
participant AttachmentView
User->>AttachmentView: Click Download Link
AttachmentView-->>Browser: Open Attachment in New Tab
Browser->>Browser: Display Attachment
Possibly related PRs
Suggested reviewers
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
nmajor25
changed the title
target='_blank' to attachment download button linktarget="_blank" to attachment download button link
RoundingWell Care Ops Frontend
|
||||||||||||||||||||||||||||
| Project |
RoundingWell Care Ops Frontend
|
| Branch Review |
attachment-download
|
| Run status |
|
| Run duration | 02m 57s |
| Commit |
|
| Committer | Nick Major |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
313
|
| View all changes introduced in this branch ↗︎ | |
Pull Request Test Coverage Report for Build 65d56f28-a1b6-468c-902f-cea9141dde60Details
💛 - Coveralls |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/js/views/patients/sidebar/action/action-sidebar-attachments-views.js(1 hunks)test/integration/patients/sidebar/action-sidebar.js(1 hunks)
🔇 Additional comments (1)
test/integration/patients/sidebar/action-sidebar.js (1)
811-815: LGTM! Good test coverage.The test properly verifies that the download link has the
target="_blank"attribute.
| @@ -26,10 +26,10 @@ const AttachmentView = View.extend({ | |||
| downloadTemplate: hbs` | |||
| <a class="action-sidebar__attachment-filename" target="_blank" href="{{_view}}">{{filename}}</a> | |||
| <div class="flex"> | |||
| <a class="action-sidebar__attachment-action flex-grow" href="{{_download}}" download> | |||
| <a class="action-sidebar__attachment-action flex-grow" target="_blank" href="{{_download}}" download> | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add rel="noopener" to prevent potential security issues.
While adding target="_blank" is correct for opening downloads in a new tab, it's recommended to also add rel="noopener" to prevent potential security vulnerabilities (reverse tabnabbing).
- <a class="action-sidebar__attachment-action flex-grow" target="_blank" href="{{_download}}" download>
+ <a class="action-sidebar__attachment-action flex-grow" target="_blank" rel="noopener" href="{{_download}}" download>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <a class="action-sidebar__attachment-action flex-grow" target="_blank" href="{{_download}}" download> | |
| <a class="action-sidebar__attachment-action flex-grow" target="_blank" rel="noopener" href="{{_download}}" download> |
Shortcut Story ID: [sc-58472]
To open download in new browser tab. Opening in current tab breaks the action sidebar.
Summary by CodeRabbit
New Features
Tests