Fix sass deprecation warnings #1379

nmajor25 · 2025-01-09T18:08:25Z

Shortcut Story ID: [sc-57510]

Main deprecation updates:

Switch from deprecated map-get() to map.get().
Switch from using deprecated @import's to @use & @forward instead.
- More info on the deprecation here.

Only used in the datepicker.scss file so we don't need to import it everywhere

coderabbitai · 2025-01-09T18:08:34Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

nmajor25 · 2025-01-09T18:09:28Z

I've got this PR set as a draft. I'd like to do more testing in my local dev environment. To make sure all the styles are working as before.

nmajor25 · 2025-01-09T18:10:00Z

vite.config.js

@@ -32,7 +32,6 @@ const css = {
    scss: {
      additionalData: `
        @use 'sass:math';
-        @use 'sass:color';


I couldn't find anywhere this is being used.

nmajor25 · 2025-01-09T18:13:24Z

src/scss/core/_base.scss

@@ -1,3 +1,5 @@
+@use '../provider-variables' as *;


The sass preprocessorOptions in the vite.config.js file adds @use 'src/scss/provider-variables.scss' as *; to the top of all our sass files? Or just the ones that are imported via javascript?

Because that didn't happen for these /src/scss/core sass files. I had to add these here for the $ prefixed variables to work.

imports never needed this because they were effectively combined into the provider-core file which would have the include but @forward compiles and namespaces an export rather than putting each partial into the same namespace

Makes sense 👍

nmajor25 · 2025-01-09T18:18:31Z

src/scss/provider-variables.scss

@@ -6,8 +6,10 @@
 //   Main Colors
 // -------------------------------------

+@use 'sass:map';


Eh this line should probably be placed above the Main Color comment...

paulfalgout

Bah.. I dislike this change to sass.. but we gotta do something.. up for whichever TBH

paulfalgout · 2025-01-09T18:44:18Z

src/scss/core/_base.scss

@@ -1,3 +1,5 @@
+@use '../provider-variables' as *;


imports never needed this because they were effectively combined into the provider-core file which would have the include but @forward compiles and namespaces an export rather than putting each partial into the same namespace

paulfalgout · 2025-01-09T18:47:03Z

src/scss/provider-core.scss

-@import 'core/space';
-@import 'core/text';
-@import 'core/typography';
+@forward 'core/reset';


So.. I'm not certain, but what we might be able to do here is:

@use '../provider-variables' as *; @use 'core/reset'; ... @use 'core/typography'; @forward 'core/base'; ... @forward 'core/typography';

I think that would put them all in the same namespace and the export them all with the shared namespacing.. but I'm not 💯 on that.

I'm also not sure that it's better..

Hmm interesting, that's worth investigating. Not sure if that will work either, but would be nice if it did!

Couldn't get this to work 😞

one other thought that might be a hair cleaner.. at least for now.. we could make a js file at the very top of index called provider-core-styles.js.. remove this file and all the _d file names.. or something and instead of using sass partials just import all of these at the top.. then they'd get the additionalData and we wouldn't have to add that to the partials.

paulfalgout · 2025-01-09T18:48:59Z

vite.config.js

-        @use 'sass:math';
-        @use 'sass:color';
-        @import 'src/scss/provider-variables.scss';
+        @use 'src/scss/provider-variables.scss' as *;


It's possible that we should remove this altogether and break up the variables into separate @use namespaces imports.. at least that seems to be what scss wants us to do.. but.. I dunno.. this pattern of having a few global scss vars hasn't hurt us at all.. and the imports would be everywhere...

So to implement this we'd need to add @use src/scss/provider-variables.scss in every .scss file? With relative paths too? Like @use ../../scss/provider-variables.scss?

When working on this I thought about doing that. But I couldn't figure out another way besides having the @use in a ton of different files.

yeah.. well I think that's sass intention in deprecating @import. They want explicit and obvious dependencies.. and for people to only use them when necessary... so they'd probably suggest against using as * and rather using as colors or something where the sass ends up color: colors.blue; In theory I agree... but in practice.. yeah.. it's so many @use when our global "if you see a $variable, you'll find it in our short list of provider-variables.scss" seems to work pretty well for us. The additionalData was always a little hacky.. but in some ways the more we fight the standard the more hacky our solutions are starting to look.. but as you said.. the alternative is just so much @use which doesn't really seem to clarify anything IMO. So I dunno. sass sucks.

cypress · 2025-01-10T00:05:04Z

RoundingWell Care Ops Frontend Run #7171

Run Properties: Failed #7171 • acb9ad814b: Add `return null;`s to our vite plugins

Project	`RoundingWell Care Ops Frontend`
Branch Review	`sass-deprecations`
Run status	`Failed #7171`
Run duration	`02m 45s`
Commit	acb9ad814b: Add `return null;`s to our vite plugins
Committer	`Nick Major`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`2`
Pending	`0`
Skipped	`0`
Passing	`312`
View all changes introduced in this branch ↗︎

Tests for review

test/integration/forms/form.js • 1 failed test • care-ops-e2e

View Output

Test		Artifacts
Noncontext Form > getIcd		`Test Replay` `Screenshots`

forms/form.js • 1 flaky test • care-ops-e2e

View Output

Test		Artifacts
Noncontext Form > update patient field		`Test Replay` `Screenshots`

patients/sidebar/filter-sidebar.js • 1 flaky test • care-ops-e2e

View Output

Test		Artifacts
filter sidebar > states sorted by sequence value		`Test Replay` `Screenshots`

coveralls · 2025-01-10T00:06:58Z

Pull Request Test Coverage Report for Build 38e295ae-97d7-44e0-b97f-9314043c8c4c

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 99.987%

Totals
Change from base Build 47b04e92-a6eb-4322-a3cf-6fcb0cf52e1a:	0.03%
Covered Lines:	6079
Relevant Lines:	6079

💛 - Coveralls

ws service supports models now.

Part of the filters work, this can currently always be added

We didn’t ever use this. Likely never will

if a socket just opens by default it’s not an issue.

It reopens during changing tests

…st items'` test

…plugin-stylelint npm packages To support vite 6

…external @modyfi/vite-plugin-yaml npm package @modyfi/vite-plugin-yaml npm package is no longer being maintained and is blocking us from moving to vite v6

Temporarily setting `css.preprocessorOptions.scss.api: 'legacy'` for vite 6 to work. We will remove that at a later date when we update sass to use the modern js api

No longer needed

… package

nmajor25 · 2025-01-15T17:14:43Z

Closing this PR and switching to a new one: #1382. I messed up a rebase.

nmajor25 added 3 commits January 9, 2025 11:41

Remove unused sass:color import

c91b3c2

Move sass:math import scope to file

a3f1f06

Only used in the datepicker.scss file so we don't need to import it everywhere

Switch from deprecated map-get() => map.get()

3d41ee3

nmajor25 requested a review from paulfalgout January 9, 2025 18:08

nmajor25 commented Jan 9, 2025

View reviewed changes

paulfalgout reviewed Jan 9, 2025

View reviewed changes

Switch @imports to @use or @forward

6cf3ac7

nmajor25 force-pushed the sass-deprecations branch from 2542573 to 6cf3ac7 Compare January 9, 2025 23:59

paulfalgout and others added 15 commits January 14, 2025 11:35

Remove subscribe getResource invoke

666fde7

ws service supports models now.

Add workspace to all websocket subscriptions

0f499ed

Part of the filters work, this can currently always be added

Remove connectionResponseData

dab4107

We didn’t ever use this. Likely never will

Use sinon stub instead of wsIntercept helper

09b6bc3

Only send data if data on socket open

ecf53d4

if a socket just opens by default it’s not an issue.

Remove reopening sockets in the test environment

ccbc637

It reopens during changing tests

Small refactors on `'action attachments - show/hide icon in action li…

09e341a

…st items'` test

Remove attaching resource and author to the notification payload

a236187

Update @cypress/vite-dev-server, cypress-vite, vite-plugin-pwa, vite-…

218be61

…plugin-stylelint npm packages To support vite 6

On vite builds, convert yaml to js object ourselves instead of using …

a1e24ff

…external @modyfi/vite-plugin-yaml npm package @modyfi/vite-plugin-yaml npm package is no longer being maintained and is blocking us from moving to vite v6

Upgrade to vite v6

fed0b68

Temporarily setting `css.preprocessorOptions.scss.api: 'legacy'` for vite 6 to work. We will remove that at a later date when we update sass to use the modern js api

Remove scss/core/_overrides.scss file

5bd463f

No longer needed

In our vite yaml plugin, use JSON.stringify() instead of tosource npm…

397c327

… package

Add try...catch to our vite yaml plugin

29bcc07

Add return null;s to our vite plugins

acb9ad8

nmajor25 mentioned this pull request Jan 15, 2025

Sass deprecation warning fixes #1382

Open

nmajor25 closed this Jan 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix sass deprecation warnings #1379

Fix sass deprecation warnings #1379

nmajor25 commented Jan 9, 2025

coderabbitai bot commented Jan 9, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

nmajor25 commented Jan 9, 2025

nmajor25 Jan 9, 2025

nmajor25 Jan 9, 2025

paulfalgout Jan 9, 2025

nmajor25 Jan 9, 2025

nmajor25 Jan 9, 2025

paulfalgout left a comment

paulfalgout Jan 9, 2025

paulfalgout Jan 9, 2025

nmajor25 Jan 9, 2025

nmajor25 Jan 10, 2025

paulfalgout Jan 13, 2025

paulfalgout Jan 9, 2025

nmajor25 Jan 9, 2025

paulfalgout Jan 10, 2025

cypress bot commented Jan 10, 2025 •

edited

Loading

coveralls commented Jan 10, 2025

nmajor25 commented Jan 15, 2025

Fix sass deprecation warnings #1379

Fix sass deprecation warnings #1379

Conversation

nmajor25 commented Jan 9, 2025

coderabbitai bot commented Jan 9, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

nmajor25 commented Jan 9, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulfalgout left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cypress bot commented Jan 10, 2025 • edited Loading

Tests for review

coveralls commented Jan 10, 2025

Pull Request Test Coverage Report for Build 38e295ae-97d7-44e0-b97f-9314043c8c4c

Details

💛 - Coveralls

nmajor25 commented Jan 15, 2025

coderabbitai bot commented Jan 9, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

cypress bot commented Jan 10, 2025 •

edited

Loading