Skip to content

[Fix] Back missing on setup Create GitHub App when steps are skipped#548

Merged
mrubens merged 1 commit into
developfrom
fix/github-create-app-back-button-38rt9zya6n3jy
Jul 18, 2026
Merged

[Fix] Back missing on setup Create GitHub App when steps are skipped#548
mrubens merged 1 commit into
developfrom
fix/github-create-app-back-button-38rt9zya6n3jy

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

Follow-up after #546 was merged — Back was missing on setup Create GitHub App.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

  • Always wires Back on the setup Create GitHub App / source-control config step.
  • When earlier steps are skipped or deep-linked (no history), Back falls through to the source-control provider chooser — matching Slack’s create-app Back behavior.
  • Covers that with a unit test on the GitHub create screen.

How it was tested

  • Targeted web vitest for StepSourceControlConfig and setup flow hooks (58 passed)
  • Pre-push (check-types:fast, residual lint, knip)
  • Browser proof of the live setup step was blocked here (local setup already complete redirects off /setup)

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

Always wire Back on the source-control config step, and fall back to the
provider chooser when prior setup steps are skipped or deep-linked.
@roomote-roomote

roomote-roomote Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed bbc87ae

@mrubens
mrubens marked this pull request as ready for review July 18, 2026 15:51
@mrubens
mrubens merged commit 99dd710 into develop Jul 18, 2026
17 checks passed
@mrubens
mrubens deleted the fix/github-create-app-back-button-38rt9zya6n3jy branch July 18, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant