Skip to content

[Feat] Support automatic Discord forum tags#531

Merged
mrubens merged 5 commits into
developfrom
agent/discord-forum-tag-routing
Jul 18, 2026
Merged

[Feat] Support automatic Discord forum tags#531
mrubens merged 5 commits into
developfrom
agent/discord-forum-tag-routing

Conversation

@mrubens

@mrubens mrubens commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. View the task or mention @roomote-roomote for follow-up asks.

Related issue

N/A — internal follow-up on automatic Discord forum tag support.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Tasks can launch in Discord forum and media channels that require tags. When a forum needs a tag, Roomote uses the small router to pick the best available unmoderated tag from the task description, then falls back deterministically if routing fails or returns an invalid id.

Forums that only expose moderated tags are no longer treated as freely usable: destination setup and automatic posting now require the Discord Manage Threads permission before applying a moderated tag. Empty required-tag forums remain unsupported with a clearer destination picker message.

Setup and install guidance now match that rule: the Add to Discord install link requests Manage Threads, and setup/docs copy explain when it is required.

How it was tested

  • Vitest: Discord provider, API Discord launch + automation delivery, forum-tag router, web comms commands, setup instructions
  • Docs check for the Discord page
  • Pre-push gate on push: oxlint, residual lint, fast type checks, knip

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

@roomote-roomote

roomote-roomote Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

No new code issues found. See task

  • packages/communication/src/discord-provider.ts:1217 Moderator-only required tags are treated as usable without checking MANAGE_THREADS. A forum containing only moderated tags passes destination setup, but posting applies that tag and Discord rejects it unless the bot has MANAGE_THREADS. Require that permission for this fallback or mark such destinations unavailable.

Reviewed 91bc517

@mrubens

mrubens commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@roomote-roomote resolve conflicts and address feedback

@roomote-roomote

Copy link
Copy Markdown
Contributor

I'm on it. I started a dedicated PR follow-up task for this request, and I'll keep updates here. See task

@roomote-roomote

roomote-roomote Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Resolved merge conflicts, gated moderated-only required-tag forums on Manage Threads, and updated install permissions plus setup/docs health copy so they match. See task

Latest: dd3000b. Revert this commit

mrubens added 2 commits July 18, 2026 13:59
Required-tag forums that only expose moderated tags now need manage_threads
for destination setup and automatic posting, so Roomote no longer treats tags
the bot cannot apply as usable.
@roomote-roomote roomote-roomote Bot changed the title Support automatic Discord forum tags [Feat] Support automatic Discord forum tags Jul 18, 2026
Add Manage Threads to the install permission bitfield and setup/docs
copy, clarifying it is only required for moderated-only required-tag
forums. Destination permission errors now use readable labels.
@mrubens

mrubens commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@roomote-roomote resolve conflicts

@roomote-roomote

Copy link
Copy Markdown
Contributor

I'm on it. I started a dedicated PR follow-up task for this request, and I'll keep updates here. See task

@roomote-roomote

Copy link
Copy Markdown
Contributor

Resolved merge conflicts with develop in the Discord task-launch tests (kept forum-tag mocks + provisional-title dbLimit setup from #541). Pre-push checks passed. See task

Latest: 91bc517. Revert this commit

@mrubens
mrubens marked this pull request as ready for review July 18, 2026 15:32
@mrubens
mrubens merged commit 82f5705 into develop Jul 18, 2026
17 checks passed
@mrubens
mrubens deleted the agent/discord-forum-tag-routing branch July 18, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant