[Improve] Prefer configured cloud sandbox provider over Local Docker#498
Merged
brunobergher merged 2 commits intoJul 17, 2026
Merged
Conversation
When Local Docker and a cloud provider are both available, default to the last catalog-ordered configured cloud instead of DEFAULT_COMPUTE_PROVIDER=docker.
Contributor
Author
|
No new code issues found. See task
Reviewed 6bbb1e8 |
brunobergher
approved these changes
Jul 17, 2026
Contributor
Author
|
Fixed the open review item.
Shipped in 6bbb1e8. |
Preserve immediate return for authoritative non-Docker DEFAULT_COMPUTE_PROVIDER and only scan configured cloud providers when resolving docker-vs-cloud fallback.
brunobergher
marked this pull request as ready for review
July 17, 2026 17:04
brunobergher
deleted the
improve/prefer-cloud-compute-default-1ryfuh61bs354
branch
July 17, 2026 17:06
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — internal request to fix the homepage/default sandbox provider when both Local Docker and a cloud provider are configured.
Why this PR exists
What changed
When Local Docker and at least one cloud sandbox provider are both configured, the default sandbox provider preference is now a configured cloud provider instead of Local Docker.
DEFAULT_COMPUTE_PROVIDER=docker(common in compose/local stacks) no longer outranks a ready cloud provider for the resolved deployment defaultHow it was tested
@roomote/typessetup-compute-config unit tests@roomote/dbcompute-runtime-config unit tests (includingresolveDefaultComputeProviderand a regression that non-Docker env defaults skip catalog env-var selects)@roomote/webHome client tests for fallback selection among available providersChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset