Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/skills/mock-telegram-testing/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ See `references/scenarios.md` for the full user-journey catalog. Common picks:
- **`unlinked-sender`** — message from an unmapped Telegram user is nudged and dropped
- **`long-reply-chunking`** — worker reply over 4096 chars splits into multiple messages
- **`cancel-button`** — callback_query cancels the running job
- **`routing-confirmation`** — low-confidence route posts a workspace picker; Nevermind is the zero-side-effect live-test path
- **`routing-confirmation`** — low-confidence route posts a workspace picker; Never mind is the zero-side-effect live-test path

LLM-judged eval scenarios live in `packages/communication/evals/scenarios/` and run via `pnpm --filter @roomote/communication eval:telegram-scenario`.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,12 @@ When the router is unsure (confidence < 0.95, workspace remapped, or all-reposit
- Expect: webhook responds `confirmationPending: true`; a compact card "Planning to run this in **{suggested}** — starting in ~5s." with one row of buttons: ✅ Yes (`route_ok:<id>`) and ✖️ Nope (`route_alt:<id>`). Router `fallback` skips the Yes/Nope step and shows the picker directly ("could not confidently pick a workspace") with no auto-start.
- Click paths:
- ✅ Yes → callback answered `Starting in {workspace}.`, the card is edited in place to "Starting in **{workspace}**." (keyboard removed), task launched.
- ✖️ Nope → the same message is edited into the picker ("Okay — where should I run this?" + one button per workspace + ✖️ Nevermind), re-keyed under a fresh pending-route id so the 5s timer can never fire the suggestion afterwards. The picker waits — no timer.
- ✖️ Nope → the same message is edited into the picker ("Okay — where should I run this?" + one button per workspace + ✖️ Never mind), re-keyed under a fresh pending-route id so the 5s timer can never fire the suggestion afterwards. The picker waits — no timer.
- Picker choice (`route_pick:<id>:<n>`) → same as Yes but with the chosen workspace.
- ✖️ Nevermind (`route_no:<id>`) → callback answered `Okay — not starting a task.`, card finalized, nothing launches (the safe path for live testing: Nope → Nevermind).
- ✖️ Never mind (`route_no:<id>`) → callback answered `Okay — not starting a task.`, card finalized, nothing launches (the safe path for live testing: Nope → Never mind).
- No click → the Yes/Nope card auto-starts the suggestion after ~5s (card edited to "Starting in **{workspace}**." when the timer fires); pickers just expire (15-min Redis TTL).
- Click from a different Telegram user → `Only the requester can choose a workspace for this task.` and the pending choice is NOT consumed.
- Assert: state `.messages` (card text edited through the stages, final `reply_markup` empty), `.callbackAnswers`; DB `cloud_jobs` for the launch (or its absence after Nevermind).
- Assert: state `.messages` (card text edited through the stages, final `reply_markup` empty), `.callbackAnswers`; DB `cloud_jobs` for the launch (or its absence after Never mind).
- Note: the pending choice is one-shot (`GETDEL`) — a second click on a stale card gets `This choice expired — send the request again.` The 5s window is too short to tap from a phone notification; that is intentional — Nope is for users watching the chat, and the started message's cancel button covers everyone else.

## 16. suggestion-button
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions apps/api/src/handlers/discord/routing-confirmation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const DISCORD_CHANNEL_TYPE_PUBLIC_THREAD = 11;
const PENDING_ROUTE_TTL_SECONDS = 15 * 60;
const PENDING_ROUTE_PREFIX = 'discord:pending_route:';
// Discord supports at most five action rows. Reserve one for All repositories
// and one for Nevermind so every stored option is also visible and actionable.
// and one for Never mind so every stored option is also visible and actionable.
const MAX_ENVIRONMENT_OPTIONS = 3;

type PendingRouteOption = {
Expand Down Expand Up @@ -140,7 +140,7 @@ function routeButtons(id: string, options: PendingRouteOption[]) {
callbackData: `discord:route:${id}:${index}`,
},
]),
[{ text: 'Nevermind', callbackData: `discord:route:${id}:cancel` }],
[{ text: 'Never mind', callbackData: `discord:route:${id}:cancel` }],
];
}

Expand Down
6 changes: 3 additions & 3 deletions apps/api/src/handlers/telegram/__tests__/index.test.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/api/src/handlers/telegram/routing-confirmation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ function buildPickerButtons(
]),
[
{
text: '✖️ Nevermind',
text: '✖️ Never mind',
callbackData: buildTelegramRouteNoCallbackData(pendingRouteId),
},
],
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/slack/src/block-kit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1385,7 +1385,7 @@ export async function showTaskConfiguration({
},
{
type: 'button',
text: { type: 'plain_text', text: 'Nevermind', emoji: true },
text: { type: 'plain_text', text: 'Never mind', emoji: true },
action_id: 'nevermind_task',
},
],
Expand Down Expand Up @@ -2952,7 +2952,7 @@ export async function handleRoutingRejectNo(payload: SlackInteractivePayload) {
}

/**
* Handles the "Nevermind" button click on the manual selection UI.
* Handles the "Never mind" button click on the manual selection UI.
* Cleans up pending state and replaces the selection message with
* a cancellation confirmation so the user knows the task was dropped.
*/
Expand Down
Loading