Skip to content

Revert "[Improve] Clarify Review Code author scope as Roomote-only vs everyone" #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 1 commit into from
Jul 17, 2026
+24 −131
Merged

Revert "[Improve] Clarify Review Code author scope as Roomote-only vs everyone" #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions apps/docs/automations.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,9 @@ These automations react to pull requests and repository state.
| **Resolve PR Conflicts** | Looks for merge conflicts and helps fix them on open PRs | Keep long-running branches from getting stuck |

For **Review Code**, decide whether Roomote should review new commits
automatically, whether automatic reviews stay limited to PRs created by Roomote
or cover PRs from everyone, and whether draft pull requests should be included.
If your team treats drafts as active collaboration, include them. If drafts are
noisy or half-formed, keep them out until they are ready.
automatically and whether draft pull requests should be included. If your team
treats drafts as active collaboration, include them. If drafts are noisy or
half-formed, keep them out until they are ready.

For **Resolve PR Conflicts**, pick a schedule, PR age cap, and label. The
label is the team-controlled opt-in for scheduled scans. Make sure the label
Expand Down
64 changes: 2 additions & 62 deletions apps/web/src/components/settings/automations/AutomationsSettings.render.client.test.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

84 changes: 19 additions & 65 deletions apps/web/src/components/settings/automations/AutomationsSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3905,79 +3905,33 @@ If unclear, send to manager channel.`}
</div>
</div>

<div className="space-y-3">
<div className="space-y-1">
<p
id="reviewer-author-scope-label"
className="text-sm font-medium"
>
Which PRs get automatic reviews?
</p>
<p className="text-xs text-muted-foreground">
Choose whether automatic reviews stay limited to PRs
created by {PRODUCT_NAME}, or include PRs from
everyone.
</p>
</div>
<RadioGroup
aria-labelledby="reviewer-author-scope-label"
value={
formState.reviewerReviewAllPullRequestAuthors
? 'all_authors'
: 'roomote_only'
}
onValueChange={(value) =>
<div className="flex items-start gap-2">
<Switch
className="mt-1"
aria-label="Review PRs from other authors"
checked={formState.reviewerReviewAllPullRequestAuthors}
onCheckedChange={(
reviewerReviewAllPullRequestAuthors,
) =>
setFormState((prev) =>
prev
? {
...prev,
reviewerReviewAllPullRequestAuthors:
value === 'all_authors',
reviewerReviewAllPullRequestAuthors,
}
: prev,
)
}
className="space-y-3"
>
<div className="flex items-start gap-2">
<RadioGroupItem
className="mt-1"
id="reviewer-scope-roomote-only"
value="roomote_only"
/>
<div className="space-y-1">
<Label
htmlFor="reviewer-scope-roomote-only"
className="text-sm font-medium cursor-pointer"
>
Only PRs created by {PRODUCT_NAME}
</Label>
<p className="text-xs text-muted-foreground">
Automatic reviews stay limited to pull requests
opened by {PRODUCT_NAME}.
</p>
</div>
</div>
<div className="flex items-start gap-2">
<RadioGroupItem
className="mt-1"
id="reviewer-scope-all-authors"
value="all_authors"
/>
<div className="space-y-1">
<Label
htmlFor="reviewer-scope-all-authors"
className="text-sm font-medium cursor-pointer"
>
PRs from everyone
</Label>
<p className="text-xs text-muted-foreground">
Include pull requests opened by people or bots
outside {PRODUCT_NAME}.
</p>
</div>
</div>
</RadioGroup>
/>
<div className="space-y-1">
<p className="text-sm font-medium">
Review PRs from other authors
</p>
<p className="text-xs text-muted-foreground">
Include pull requests opened by people or bots outside
{` ${PRODUCT_NAME}`} in automatic reviews.
</p>
</div>
</div>

<div className="flex items-start gap-2">
Expand Down
Loading