Skip to content

[Fix] OpenAI provider section missing when ChatGPT is also connected#470

Merged
mrubens merged 1 commit into
developfrom
fix/openai-section-when-chatgpt-connected-0xc74n19if5yd
Jul 17, 2026
Merged

[Fix] OpenAI provider section missing when ChatGPT is also connected#470
mrubens merged 1 commit into
developfrom
fix/openai-section-when-chatgpt-connected-0xc74n19if5yd

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

N/A — internal bug report from Slack.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

When a ChatGPT subscription was connected, every openai/ model was listed under ChatGPT (subscription), which hid the OpenAI provider section even if an OpenAI API key was also connected.

Model lists now keep the OpenAI section when an OpenAI key is present. ChatGPT-only connections still group openai/ models under ChatGPT. Runtime auth still prefers the subscription when both are configured (existing Inference Providers notice is unchanged).

How it was tested

  • Package Vitest: types model-provider-config plus web ModelSettingsSection and ModelSelect client tests
  • Pre-push gates: oxlint, residual web/worker ESLint, check-types:fast, knip
  • Browser proof of the dual-connected admin settings state was not captured: the sandbox cannot yield a real dual-connected ChatGPT OAuth + OpenAI key fixture for that UI path

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

Only remap openai/ models under ChatGPT when the subscription is the
sole OpenAI-facing connection, so the OpenAI section stays visible
when an API key is present too.
@roomote-roomote

roomote-roomote Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed db0f02d

@mrubens
mrubens marked this pull request as ready for review July 17, 2026 04:55
@mrubens
mrubens merged commit 5ebc032 into develop Jul 17, 2026
17 checks passed
@mrubens
mrubens deleted the fix/openai-section-when-chatgpt-connected-0xc74n19if5yd branch July 17, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant