Skip to content

Clarify Azure DevOps Entra setup#434

Merged
brunobergher merged 2 commits into
developfrom
bb/ado-fixes
Jul 16, 2026
Merged

Clarify Azure DevOps Entra setup#434
brunobergher merged 2 commits into
developfrom
bb/ado-fixes

Conversation

@brunobergher

Copy link
Copy Markdown
Collaborator

Summary

  • clarify that an existing Teams Entra app can be reused after adding Azure DevOps access
  • show the ADO OAuth redirect URI only for delegated auth setup
  • clarify service principal setup copy and the ADO organization slug label

Tests

  • pnpm lint:fast
  • pnpm check-types:fast
  • pre-push hook: oxlint, residual lint, check-types:fast, knip

@roomote-roomote

roomote-roomote Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

  • apps/web/src/app/(onboarding)/setup/AdoSourceControlConfig.tsx:134 Point the "Entra Enterprise Apps" link at the Enterprise applications pane. It now targets the Enterprise applications blade, where users can copy the service principal object ID required by Azure DevOps.
  • packages/types/src/setup-source-control-config.ts:311 Update the existing assertions for the renamed organization label. StepSourceControlConfig.client.test.tsx:387 and SourceControlConfigForm.client.test.tsx:271 now expect "ADO Organization (URL slug)", and both targeted web test files pass.

Reviewed 4598ac3

@brunobergher

Copy link
Copy Markdown
Collaborator Author

Addressed the outstanding review item by pointing the Entra Enterprise Apps link at the Enterprise applications pane instead of App registrations.

@brunobergher
brunobergher merged commit e55daaf into develop Jul 16, 2026
17 checks passed
@brunobergher
brunobergher deleted the bb/ado-fixes branch July 16, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant