fix: isolate managed-provider app naming from BYO Modal's MODAL_APP_NAME#426
Merged
Merged
Conversation
resolveRoomoteCloudModalAppName gave MODAL_APP_NAME precedence as an escape hatch, but that env var belongs to the bring-your-own Modal provider: a deployment customizing its BYO app name would also redirect the managed provider's sandboxes inside the hosting operator's shared workspace, defeating per-deployment attribution. The managed provider now ignores MODAL_APP_NAME entirely and gets its own deployment-managed override, ROOMOTE_CLOUD_APP_NAME (catalog field with DB-fallback resolution, reserved from the env editor, stripped from task sandboxes), with the slug mapping roomote-<slug> as the default.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #402, prompted by review on the hosting-operator side.
resolveRoomoteCloudModalAppNamegaveMODAL_APP_NAMEprecedence as an escape hatch — but that env var belongs to the bring-your-own Modal provider. A deployment that customizes its BYO Modal app name would therefore also redirect the managed provider's sandboxes inside the hosting operator's shared workspace, defeating per-deployment attribution (and mixing tenants' usage under one app).MODAL_APP_NAMEentirely (pinned by a test).ROOMOTE_CLOUD_APP_NAME— deployment-managed like the rest of theROOMOTE_CLOUD_*family: catalog field with encrypted-env fallback resolution, reserved from the generic env editor, stripped from task sandboxes.ROOMOTE_CLOUD_APP_NAME→roomote-<slug>→ client default. Plain BYO Modal continues to read onlyMODAL_APP_NAME; neither provider consults the other's variable.Validation: lint / check-types clean; types, env, compute-providers, and controller suites green.