Skip to content

[Refactor] Remove customizable Vibes settings#396

Merged
brunobergher merged 1 commit into
developfrom
feature/remove-vibes-settings-09fu0stqgvbk8
Jul 15, 2026
Merged

[Refactor] Remove customizable Vibes settings#396
brunobergher merged 1 commit into
developfrom
feature/remove-vibes-settings-09fu0stqgvbk8

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Bruno Bergher. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

Removes the Vibes admin settings page and all deployment-level customization behind it:

  • Deletes the Vibes UI, navigation entry, tRPC API, and public docs page
  • Drops style_guidance, slack_summon_emoji, slack_ack_emoji, and slack_completion_emoji from deployment_settings (migration 0012_motionless_mauler)
  • Keeps fixed Slack lifecycle reactions (eyes, white_check_mark, x, and thumbsdown/-1 for closed PRs) as non-customizable defaults
  • Keeps the default Roomote tone/style guidance as a discrete file, with no organization override path
  • Removes emoji-reaction agent summoning entirely

Why this change was made

Vibes mixed optional branding knobs (custom reactions, summon emoji, tone overrides) into product settings and scattered them through Slack launch and agent prompt paths. The product direction is to keep a small fixed set of reactions and the built-in tone, without per-deployment customization or emoji-as-task-entry.

Impact

  • Admins no longer see or configure Vibes settings
  • Existing customized values are dropped (no legacy migration for user data)
  • Slack tasks still use fixed ack/completion/cancel reactions; reaction-based summon no longer starts tasks
  • Style overrides no longer layer onto the default Roomote tone

Screenshots

Authenticated admin Settings navigation without Vibes

Drop the Vibes settings UI, API, and deployment-level overrides. Keep fixed
Slack lifecycle reactions and the default Roomote tone file, and remove
emoji-based agent summoning.
@roomote-roomote

roomote-roomote Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

1 issue outstanding. See task

  • apps/worker/src/callbacks/slack-mention.ts:649-650 Preserve the payload's acknowledgement emoji when cleaning up in-flight runs created before this deploy. Those runs can already have a custom reaction applied and persisted; always removing eyes leaves the actual reaction behind and triggers the retry/warn path, while falling back to the default only when the payload omits ackEmoji keeps all new runs fixed to eyes.

Reviewed feb47e3

@brunobergher brunobergher marked this pull request as ready for review July 15, 2026 18:50
@brunobergher brunobergher merged commit 6228f26 into develop Jul 15, 2026
18 checks passed
@brunobergher brunobergher deleted the feature/remove-vibes-settings-09fu0stqgvbk8 branch July 15, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants