[Feat] Make closed PR Slack reaction configurable with default ❌#360
Closed
roomote-roomote[bot] wants to merge 2 commits into
Closed
[Feat] Make closed PR Slack reaction configurable with default ❌#360roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
Author
Contributor
|
@roomote-roomote resolve conflicts |
Contributor
Author
|
I'm on it. I routed this request into the existing PR task so follow-up work stays on one Roomote thread for this PR, and I'll keep updates here. See task |
…le-closed-pr-emoji-1y2cf6szgeqx8
Contributor
Author
|
Resolved merge conflicts in:
Renumbered this PR's migration to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Closed PR Slack reactions are no longer hard-coded to
heavy_multiplication_x. Deployments now default to:x:(x) and admins can change the emoji under Settings → Vibes → Custom reaction emoji.Merged PRs still use the existing completion emoji; only closed-without-merge terminal notifications use the new closed-PR preference.
Why this change was made
Teams wanted
:x:as the closed-PR signal and a way to tune it the same way acknowledgement and completion reactions already work.Impact
xfor new and unset deploymentsdeployment_settings.slack_pr_closed_emojiScreenshots