Skip to content

[Feat] Make closed PR Slack reaction configurable with default ❌#360

Closed
roomote-roomote[bot] wants to merge 2 commits into
developfrom
feature/configurable-closed-pr-emoji-1y2cf6szgeqx8
Closed

[Feat] Make closed PR Slack reaction configurable with default ❌#360
roomote-roomote[bot] wants to merge 2 commits into
developfrom
feature/configurable-closed-pr-emoji-1y2cf6szgeqx8

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

Closed PR Slack reactions are no longer hard-coded to heavy_multiplication_x. Deployments now default to :x: (x) and admins can change the emoji under Settings → Vibes → Custom reaction emoji.

Merged PRs still use the existing completion emoji; only closed-without-merge terminal notifications use the new closed-PR preference.

Why this change was made

Teams wanted :x: as the closed-PR signal and a way to tune it the same way acknowledgement and completion reactions already work.

Impact

  • Default closed-PR reaction becomes x for new and unset deployments
  • Vibes settings gains a required Closed PR emoji field with reset-to-default
  • Public Vibes docs include the new setting
  • Requires a DB migration for deployment_settings.slack_pr_closed_emoji

Screenshots

Closed PR emoji control on Settings → Vibes with default value x

@roomote-roomote

roomote-roomote Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

No new code issues found. See task

Reviewed b2d6bf6

@mrubens

mrubens commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@roomote-roomote resolve conflicts

@roomote-roomote

Copy link
Copy Markdown
Contributor Author

I'm on it. I routed this request into the existing PR task so follow-up work stays on one Roomote thread for this PR, and I'll keep updates here. See task

@roomote-roomote

Copy link
Copy Markdown
Contributor Author

Resolved merge conflicts in:

  • packages/db/drizzle/meta/0011_snapshot.json
  • packages/db/drizzle/meta/_journal.json
  • packages/types/src/slack.ts

Renumbered this PR's migration to 0012_broad_pretty_boy so it can sit after develop's 0011_generalized_llm_usage. Kept both DEFAULT_SLACK_PR_CLOSED_EMOJI and develop's DEFAULT_SLACK_CANCEL_EMOJI.

@mrubens mrubens closed this Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant