[Improve] Guide kickoff messages to end with a period#355
Merged
Conversation
Guide the router to write short complete kickoff sentences ending with a period via prompt, schema, and eval wording only.
Contributor
Author
|
No code issues found. See task
Reviewed 23c4023 |
Contributor
Author
Cover representative basic and model-routing cases so missing or period-less kickoffMessage values fail the router eval suite.
Pass includeKickoffMessage so the suite evaluates the production kickoff contract, and require a non-null kickoffMessage field in the eval output format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — follow-up after #353 still left kickoff messages without trailing punctuation in practice.
Why this PR exists
What changed
Prompt-only guidance plus eval coverage so router kickoffs are short complete sentences ending with a period.
hasValidKickoffMessageto the router eval assertions (non-empty + trailing period)basicandmodel-routingcasesincludeKickoffMessage: truekickoffMessagestring in the eval output formatNo runtime force-normalization or static-template punctuation changes.
How it was tested
Pre-push
lint:fast,check-types:fast, andknippassed. Fullpnpm eval:routerwas not run in this environment (needs live LLM provider keys); the assertion and prompt flags are wired into the existing Promptfoo suite.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetImpact
Router prompt + schema encourage sentence-ending periods on dynamic kickoffs, and the router eval suite regresses that contract with the production kickoff section enabled.