[Feat] Block environment verification with manage_tasks await#334
Draft
roomote-roomote[bot] wants to merge 4 commits into
Draft
[Feat] Block environment verification with manage_tasks await#334roomote-roomote[bot] wants to merge 4 commits into
roomote-roomote[bot] wants to merge 4 commits into
Conversation
Block server-side on follow-up task settlement so environment-setup can own verification with one job call instead of model-driven poll loops.
Contributor
Author
|
No new code issues found. See task
Reviewed 51bbbc4 |
Contributor
Author
Do not settle stopped/shutting_down runs as ready, prefer latest run failed/canceled over completed, and require get_messages before env setup reports readiness.
A single failed getTaskSummary poll (platform-API stall, rolling restart, or a launch/enqueue race before the run row exists) previously aborted the whole await. Absorb transient read failures and keep polling until the task settles; surface a retryable error only once reads keep failing past a bounded grace window (2m) or the overall timeout elapses. Also document why holding one tool call open for minutes is safe in the OpenCode runtime. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
No GitHub issue. Internal reliability work from Slack-owned investigation into post-create environment verification (soft agent poll loops were not reliable).
Why this PR exists
Slice A of platform-owned environment verification: ownership of verification must not depend on model-driven
get_summarypolling while the parent turn can go Idle/Ready mid-boot. Follow-up review fixed misclassification of stopping/failed runs and required message success before readiness claims.What changed
manage_tasksactionawait: server-side blocks/polls a task summary until it settles (Completed / Failed / Canceled / Ready / Idle / NeedsInput) or times out (default 25m, max 45m).stopped/shutting_downruns active (not ready).environment-setupnow does list_environments → launch verification → await → required get_messages success assertion → bounded env-definition repair (≤2 extra full cycles) → report.How it was tested
vitestforawait-tasksettlement/timeout/classification (+ fail-over-completed and stopped phase cases)vitestforenvironmentSetupSkillcontract stringsChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset