Skip to content

[Improve] Refine task conversation activity presentation#317

Merged
brunobergher merged 14 commits into
developfrom
feature/collapse-same-type-tool-calls-2t9s0slkhwijj
Jul 16, 2026
Merged

[Improve] Refine task conversation activity presentation#317
brunobergher merged 14 commits into
developfrom
feature/collapse-same-type-tool-calls-2t9s0slkhwijj

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Bruno Bergher. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

N/A — internal product cleanup requested over Slack.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

This refreshes task conversation presentation so completed activity reads as compact progress instead of a long stream of repetitive implementation detail.

  • Consecutive same-type tool calls collapse into one multi-call row after the second call settles, including shell/execute calls and missing-toolCallId call/result pairs.
  • Background reasoning, tool calls, and tool results can collapse into activity groups around assistant text and todo/progress boundaries.
  • Todo markers stay visible as progress boundaries inside historical and live activity, including leading activity before the rendered prompt.
  • ACP group rows, tool details, command output, and generic multi-call labels were tuned for lighter, more readable presentation.
  • Task UI affordances around draft prompts, pending request panels, subtasks, and the wake input tray were aligned with the updated conversation layout.
  • Added/updated focused client coverage for task messages, todo boundaries, wake input behavior, ACP activity grouping, grouped tool rendering, anchors, and tool detail presentation.

How it was tested

  • pnpm exec oxlint --deny-warnings
  • pnpm knip
  • Pre-push hook passed: oxlint, residual turbo lint for @roomote/web and @roomote/worker, pnpm check-types:fast, and pnpm knip

Browser screenshots were not captured: no Storybook story for this component, and the seeded sandbox transcript does not reliably include enough representative completed activity to show the collapsed UI honestly.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

@roomote-roomote

roomote-roomote Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

No new code issues found. See task

  • apps/web/src/app/(sandbox)/task/[taskId]/messages/acp/render-blocks.ts:469-477 — Generic grouped tool headers. Fixed earlier.
  • apps/web/src/app/(sandbox)/task/[taskId]/messages/acp/render-blocks.ts:383-385 — Dead subagent display kind. Fixed earlier.
  • apps/web/src/app/(sandbox)/task/[taskId]/messages/acp/render-blocks.ts:873-889 — Missing toolCallId call/result pair. Fixed earlier.
  • apps/web/src/app/(sandbox)/task/[taskId]/messages/acp/render-blocks.ts:577-585 — Repeated no-toolCallId ops collapsed into one. Fixed: missing ids only pair consecutive call→result; same-signature settled results stay distinct.
  • apps/web/src/app/(sandbox)/task/[taskId]/messages/acp/activity-groups.ts:84-104 — Live partial reasoning/tool activity hidden in collapsed groups. Fixed: partial / in-progress blocks are not activity-collapsible.
  • apps/web/src/app/(sandbox)/task/[taskId]/messages/acp/AcpCommandOutputMessage.tsx:49-51,69-77 — Non-zero exit status not shown. Fixed: restored → exit N / failed status cue.
  • apps/web/src/app/(sandbox)/task/[taskId]/WakeTaskInput.tsx:134 / WakeTaskInput.client.test.tsx:263 — Placeholder test out of date. Fixed: assertion matches Wake up Roomote with a message....

Reviewed 83bb1018

@roomote-roomote

roomote-roomote Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Addressed all 3 open review items on this PR in 81b63f1:

  1. Generic multi-call headers now read like Used 2 get issue calls (and Edited N files for edit tools).
  2. Removed the unreachable subagent display-kind branch.
  3. Missing toolCallId call/result pairs are deduped by payload signature so one invocation no longer becomes two group items.

Validation: @roomote/web typecheck + grouping Vitest (44 tests).

See task

@brunobergher brunobergher force-pushed the feature/collapse-same-type-tool-calls-2t9s0slkhwijj branch from 81b63f1 to daab267 Compare July 16, 2026 05:21
@brunobergher brunobergher changed the title [Improve] Collapse consecutive same-type completed tool calls in chat [Improve] Refine task conversation activity presentation Jul 16, 2026
@brunobergher brunobergher force-pushed the feature/collapse-same-type-tool-calls-2t9s0slkhwijj branch from daab267 to 1651d98 Compare July 16, 2026 05:24
@roomote-roomote

roomote-roomote Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the remaining open review items and the failing Test jobs in 05517c94 / 83bb1018:

  1. No-toolCallId dedupe only pairs consecutive call→result; repeated same-signature results stay separate.
  2. Live partial / in-progress reasoning and tools stay outside default-closed activity groups.
  3. Restored non-zero command exit status (→ exit 1).
  4. Wake-input placeholder test matches the current copy.

Focused Vitest + web typecheck green.

See task

roomote added 2 commits July 16, 2026 05:41
Pair missing-toolCallId call/result only when consecutive, leave live
partial activity outside collapsed groups, restore non-zero exit status
on command rows, and align wake-input placeholder test copy.
@brunobergher brunobergher marked this pull request as ready for review July 16, 2026 05:50
@brunobergher brunobergher merged commit 7adea7a into develop Jul 16, 2026
18 checks passed
@brunobergher brunobergher deleted the feature/collapse-same-type-tool-calls-2t9s0slkhwijj branch July 16, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants