[Improve] Expand source-control setup and OAuth flows#295
Merged
brunobergher merged 31 commits intoJul 14, 2026
Conversation
Contributor
Author
|
All identified review and CodeQL issues addressed.
Fixed in 623d44e |
0328a16 to
a3f9541
Compare
Contributor
Author
|
Addressed all review findings and the CodeQL alerts in 623d44e. Gitea setup now uses one deployment callback, ambiguous issue comments cannot launch PR tasks, path-prefixed OAuth and proxy handling remains covered, and GitLab/Gitea trailing-slash normalization no longer uses the polynomial regexes. The CodeQL gate and JavaScript/TypeScript analysis pass on the final head; the affected tests, type checks, lint, docs validation, and pre-push checks also pass. Browser proof was unavailable because the managed local preview remained unresponsive. |
brunobergher
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
GitLab and Gitea needed deployment-friendly OAuth paths whose onboarding guidance, repository synchronization, webhook handling, and comment triggers agree on the same connection model. The follow-up fixes also ensure Gitea's single-callback constraint and ambiguous issue events cannot produce broken authorization or unintended PR tasks.
Impact
New deployments can connect GitLab and Gitea through OAuth with correct support for self-managed base paths, while Bitbucket, GitLab, and Gitea setup guidance remains focused on the required path. All identified review findings are addressed, the previously failing web Settings test now passes, and both the CodeQL gate and JavaScript/TypeScript analysis pass on the final head. Browser screenshots remain unavailable because the managed local web preview did not respond after the allowed restart.