[Refactor] Complete R_ prefix for remaining Roomote-owned env vars#274
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Refactor] Complete R_ prefix for remaining Roomote-owned env vars#274roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Rename leftover operator-facing Roomote config (compute selection/Docker worker policy, preview/tRPC URLs, Slack/source-control app settings, API thresholds) to R_*, with a DB migration for stored deployment env vars.
Contributor
Author
|
2 issues outstanding. See task Reviewed the
Reviewed a049d54 |
Contributor
|
Thank you for your contribution! Before we can merge this pull request, we need you to sign our Contributor License Agreement. You can sign it by posting the comment below. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
| if (!env.SLACK_AUTH_URI && env.R_APP_URL) { | ||
| env.SLACK_AUTH_URI = `${env.R_APP_URL.replace(/\/+$/, '')}/api/slack/auth`; | ||
| if (!env.R_SLACK_AUTH_URI && env.R_APP_URL) { | ||
| env.R_SLACK_AUTH_URI = `${env.R_APP_URL.replace(/\/+$/, '')}/api/slack/auth`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Roomote does not generally accept unsolicited community pull requests. Unless a maintainer invited this PR in an issue or discussion, it will likely be closed without review. A well-written issue is the best way to contribute.
Related issue
N/A — maintainer follow-up to complete the earlier
R_*env-var consolidation.Why this PR exists
What changed
Finished aligning remaining Roomote-owned operator env vars with the
R_*naming contract after the earlier consolidation left compute, preview, and non-GitHub source-control app settings on older names.R_DEFAULT_COMPUTE_PROVIDER,R_EXCLUDED_COMPUTE_PROVIDERS,R_DOCKER_*,R_BLAXEL_STANDBY_*R_TRPC_URL,R_PREVIEW_*GITLAB_TOKEN, etc.) unprefixed for sandbox toolingR_WORKER_RELEASE_*0010_more_canonical_r_env_vars.sqlto rename stored deployment env-var rows (no dual-read aliases)Left conventional infra (
DATABASE_URL,S3_*, signing secrets), local-dev knobs (WEB_DEV_LOGIN_*), third-party compute SDK credentials (MODAL_*,E2B_*, …), and model API keys unprefixed.Operators upgrading must switch platform/export env names to the new
R_*forms; product behavior and third-party credential contracts are unchanged.How it was tested
pnpm lint:fastpnpm check-types:fastpnpm knip(via pre-push)@roomote/env,@roomote/typescompute/source-control/control-plane,@roomote/dbcompute-runtime-config,@roomote/slackapi-base-url/web-client,@roomote/compute-providersfactory,@roomote/gitlab+@roomote/giteaAPI testsChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset