[Improve] Skip “CI is passing” padding in PR review notifications#244
Merged
mrubens merged 1 commit intoJul 12, 2026
Merged
Conversation
When review findings are already actionable, omit "CI is passing" mentions and keep focus on offers to fix comments, failed checks, or conflicts.
Contributor
Author
|
No code issues found. See task This change is prompt-only: it refines the PR-review notification triage system prompt to skip "CI is passing" padding when there is already actionable feedback, and only mention green CI when nothing else is actionable. The rules read coherently with the surrounding prompt (failed CI and merge conflicts stay high-signal). The test additions correctly assert the new prompt strings, and the full Reviewed 90f1986 |
mrubens
marked this pull request as ready for review
July 12, 2026 13:06
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 12, 2026 13:06
mrubens
deleted the
improve/pr-review-skip-passing-ci-padding-2y2s7nk92miv2
branch
July 12, 2026 13:06
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PR review notification triage now tells the model to focus chat copy on actionable offers — open review feedback, failed CI, or merge conflicts — and to skip “CI is passing” / all-green padding whenever findings are already worth acting on. Green CI is only mentioned when there is nothing else actionable (for example a clean self-review with no issues). Failed checks and conflicts stay high-signal CTAs.
Why this change was made
When Roomote flagged real findings, messages were still finishing with “All listed CI checks are passing,” which diluted the offer to help. Notifications should lead with the fixable problem, not burn space on green status.
Impact
Users get tighter PR review notification copy that emphasizes “want me to look at this comment / failure / conflict?” and only mentions successful CI when that is the useful context left.