Skip to content

[Improve] Skip “CI is passing” padding in PR review notifications#244

Merged
mrubens merged 1 commit into
developfrom
improve/pr-review-skip-passing-ci-padding-2y2s7nk92miv2
Jul 12, 2026
Merged

[Improve] Skip “CI is passing” padding in PR review notifications#244
mrubens merged 1 commit into
developfrom
improve/pr-review-skip-passing-ci-padding-2y2s7nk92miv2

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

PR review notification triage now tells the model to focus chat copy on actionable offers — open review feedback, failed CI, or merge conflicts — and to skip “CI is passing” / all-green padding whenever findings are already worth acting on. Green CI is only mentioned when there is nothing else actionable (for example a clean self-review with no issues). Failed checks and conflicts stay high-signal CTAs.

Why this change was made

When Roomote flagged real findings, messages were still finishing with “All listed CI checks are passing,” which diluted the offer to help. Notifications should lead with the fixable problem, not burn space on green status.

Impact

Users get tighter PR review notification copy that emphasizes “want me to look at this comment / failure / conflict?” and only mentions successful CI when that is the useful context left.

When review findings are already actionable, omit "CI is passing" mentions
and keep focus on offers to fix comments, failed checks, or conflicts.
@roomote-roomote

roomote-roomote Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

This change is prompt-only: it refines the PR-review notification triage system prompt to skip "CI is passing" padding when there is already actionable feedback, and only mention green CI when nothing else is actionable. The rules read coherently with the surrounding prompt (failed CI and merge conflicts stay high-signal). The test additions correctly assert the new prompt strings, and the full pr-review-notification-delivery suite passes (23/23). The CHANGELOG.md markdown-escape tweak (R\_\*) is cosmetic and harmless.

Reviewed 90f1986

@mrubens
mrubens marked this pull request as ready for review July 12, 2026 13:06
@mrubens
mrubens merged commit 238a6b1 into develop Jul 12, 2026
14 checks passed
@mrubens
mrubens deleted the improve/pr-review-skip-passing-ci-padding-2y2s7nk92miv2 branch July 12, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant